Fix runString temp path to use tmpdir() and add regression test#320
Open
dusan-maintains wants to merge 1 commit intoextrabacon:masterfrom
Open
Fix runString temp path to use tmpdir() and add regression test#320dusan-maintains wants to merge 1 commit intoextrabacon:masterfrom
dusan-maintains wants to merge 1 commit intoextrabacon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PythonShell.runString()temp file path generation by callingtmpdir()instead of using the function reference.PythonShell.runwithout spawning Python.Why
filePathwithtmpdir + sep + ..., which uses the function object instead of the temp directory path.writeFileSync, makingrunString()fragile.Test Plan
npm test -- --grep "temporary file in the OS temp directory"1 passing.Compatibility