feat(callable): add CachedCallable for cached function resolution#700
Draft
ptondereau wants to merge 1 commit intomasterfrom
Draft
feat(callable): add CachedCallable for cached function resolution#700ptondereau wants to merge 1 commit intomasterfrom
ptondereau wants to merge 1 commit intomasterfrom
Conversation
Bencher Report
ptondereau
force-pushed
the
refactor/callable-cache
branch
3 times, most recently
from
d203f5b to
70352fa
Compare
Adds `CachedCallable` type that caches `zend_fcall_info_cache` for
repeated PHP function calls from Rust, skipping expensive string
lookups and hash table searches on subsequent invocations.
- `ZendCallable::cache()` resolves once via `zend_is_callable_ex`
- `CachedCallable::try_call{,_with_named,_named}` calls via cached fcc
- `CachedCallableError` enum with typed recovery (exceptions recoverable,
engine failure poisons)
- C wrappers for `zend_fcc_addref`/`zend_fcc_dtor` (inline, not bindgen-reachable)
- Integration tests, gungraun benchmarks, guide docs
ptondereau
force-pushed
the
refactor/callable-cache
branch
from
70352fa to
2fc8942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
CachedCallabletype that cacheszend_fcall_info_cachefor repeated PHP function calls from Rust, skipping expensive string lookups and hash table searches on subsequent invocations.ZendCallable::cache()resolves once viazend_is_callable_exCachedCallable::try_call{,_with_named,_named}calls via cached fccCachedCallableErrorenum with typed recovery (exceptions recoverable, engine failure poisons)