POC: Tar ball compressed bindings#245
Closed
andyquinterom wants to merge 5 commits intoextendr:masterfrom
Closed
Conversation
Member
|
Okay, while this is nice I believe we do something like that "downstream" in I would like to say that I've benefitted from seeing this approach. It looks so clean... You seem very capable at this stuff, would you mind taken a look at my little POC over at #242? It has been a long time ambition of mine, and I think I've gotten it far, but Windows and Paths are still messing with me. |
CGMossa
reviewed
Jun 13, 2024
Comment on lines
-344
to
+348
| if ! git diff-index --quiet HEAD -- bindings/; then | ||
| if ! git diff-index --quiet HEAD -- bindings.tar.xz; then |
Member
There was a problem hiding this comment.
This should still be a diff on the text files and then just push the tar-file if needed.
I also think the tar-file should be pushed using git lfs right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just an idea I had to make the bundle size of libR-sys smaller for CRAN compliance.