Conversation
bjohansebas
force-pushed
the
windows-test-v2
branch
2 times, most recently
from
32d90f3 to
229e609
Compare
bjohansebas
force-pushed
the
windows-test-v2
branch
7 times, most recently
from
a57b64f to
c82db2c
Compare
|
Apparently there's an issue with npm. I have no idea why, but it shouldn't be related to this PR. However, it's something we need to fix if it's affecting the CI. |
bjohansebas
force-pushed
the
windows-test-v2
branch
from
a858dca to
5ddb90a
Compare
raphendyr
left a comment
raphendyr
left a comment
There was a problem hiding this comment.
Some shell scripting notes, including notes from shellcheck.
bjohansebas
force-pushed
the
windows-test-v2
branch
2 times, most recently
from
6c83144 to
3f081b2
Compare
| "eslint-plugin-markdown": "3.0.1", | ||
| "express": "4.17.3", | ||
| "mocha": "10.2.0", | ||
| "nyc": "15.1.0", |
There was a problem hiding this comment.
To fix a small issue with Windows during installation
bjohansebas
force-pushed
the
windows-test-v2
branch
from
27e866d to
8fc9cce
Compare
|
The CI passes 🥳, wow, i really struggled with the old versions of Node.js. |
package.json
Outdated
| "scripts": { | ||
| "lint": "eslint . && node ./scripts/lint-readme.js", | ||
| "test": "./test/support/gencert.sh && mocha --require test/support/env --check-leaks --bail --no-exit --reporter spec test/", | ||
| "test": "bash test/support/gencert.sh && mocha --require test/support/env --check-leaks --reporter spec test/", |
There was a problem hiding this comment.
And while we're at it, let's remove '--bail' so we can see which tests fail simultaneously instead of one by one
raphendyr
left a comment
raphendyr
left a comment
There was a problem hiding this comment.
Looks good to me (specially the shell part). I verified on my macos with npm run test and ./test/support/gencert.sh.
|
I just tried it now that I have Windows, and this doesn't work. |
bjohansebas
force-pushed
the
windows-test-v2
branch
2 times, most recently
from
a678afe to
bc8e000
Compare
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
bjohansebas
force-pushed
the
windows-test-v2
branch
from
bc8e000 to
695134e
Compare
3 participants
Related nodejs/citgm#1095 (comment)