[codex] Clarify app.render view resolution#2310
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
a35aea9 to
98032b7
Compare
Author
|
I took a pass at rebasing this over the current Astro migration. The conflict is mechanical: the old Jekyll include files for
I resolved that locally and validated it with:
The full build completed successfully ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of Problem
The
app.render('email', ...)examples do not explain where Express looks for theemailview. Issue #1457 asks where that template file is expected to live and how Express resolves it.Closes #1457.
Proposed Solution
Add a short explanation to the English 3.x, 4.x, and 5.x
app.renderAPI includes:viewcan be absolute or relative to theviewssettingview enginesettingviews = './views'andview engine = 'pug',app.render('email', ...)renders./views/email.pugAdditional Information
Validation:
npm cinpm testgit diff --checkI also attempted
bundle exec jekyll build. Local Ruby is 3.4.8 while this repo pins Ruby 3.3.4, and Jekyll failed locally withcannot load such file -- erbunder Ruby 3.4. Bundler was installed intovendor/bundlefor the attempt;vendoris ignored and no generated bundle files are included in this PR.