Skip to content

[codex] Clarify app.render view resolution#2310

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
expressjs:mainfrom
Sean-Kenneth-Doherty:codex/app-render-view-resolution
Open

[codex] Clarify app.render view resolution#2310
Sean-Kenneth-Doherty wants to merge 1 commit into
expressjs:mainfrom
Sean-Kenneth-Doherty:codex/app-render-view-resolution

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Description of Problem

The app.render('email', ...) examples do not explain where Express looks for the email view. Issue #1457 asks where that template file is expected to live and how Express resolves it.

Closes #1457.

Proposed Solution

Add a short explanation to the English 3.x, 4.x, and 5.x app.render API includes:

  • view can be absolute or relative to the views setting
  • extensionless names use the view engine setting
  • with views = './views' and view engine = 'pug', app.render('email', ...) renders ./views/email.pug

Additional Information

Validation:

  • npm ci
  • npm test
  • git diff --check

I also attempted bundle exec jekyll build. Local Ruby is 3.4.8 while this repo pins Ruby 3.3.4, and Jekyll failed locally with cannot load such file -- erb under Ruby 3.4. Bundler was installed into vendor/bundle for the attempt; vendor is ignored and no generated bundle files are included in this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 17, 2026

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 98032b7
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/6a1779aa4ba0940008706a92
😎 Deploy Preview https://deploy-preview-2310--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 87 (🔴 down 13 from production)
Best Practices: 100 (no change from production)
SEO: 94 (🔴 down 6 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty marked this pull request as ready for review May 17, 2026 06:41
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty requested a review from a team as a code owner May 17, 2026 06:41
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty force-pushed the codex/app-render-view-resolution branch from a35aea9 to 98032b7 Compare May 27, 2026 23:09
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

I took a pass at rebasing this over the current Astro migration. The conflict is mechanical: the old Jekyll include files for app.render() were deleted upstream, and the same clarification now belongs in:

  • src/content/api/3x/api/application/index.mdx
  • src/content/api/4x/api/application/index.mdx
  • src/content/api/5x/api/application/index.mdx

I resolved that locally and validated it with:

  • npm run format:check
  • npm run lint
  • npm run build

The full build completed successfully (1222 page(s) built). I can't push the merge commit from this environment because updating the branch across the Astro migration touches new/changed .github/workflows/* files, and GitHub rejects this OAuth token without workflow scope. I restored the PR branch to its previous head so I wouldn't leave noisy workaround commits behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Res.Render documentation missing information.

1 participant