fix(res.set): keep unknown Content-Type values instead of 'false'#7071
Closed
ericpan17 wants to merge 1 commit intoexpressjs:masterfrom
Closed
fix(res.set): keep unknown Content-Type values instead of 'false'#7071ericpan17 wants to merge 1 commit intoexpressjs:masterfrom
ericpan17 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Contributor
|
Duplicate of #7035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
res.set('Content-Type', value)behavior whenmime.contentType(value)cannot resolve a known type.Currently, unresolved values can become the literal header
Content-Type: false.This change preserves the original input value instead.
Changes
res.setcontent-type normalization branch:value = mime.contentType(value)value = mime.contentType(value) || valueshould keep unknown Content-Type valuesWhy
res.type()already uses this fallback strategy. This alignsres.set('Content-Type', ...)with that behavior and avoids invalid-looking header output.Validation
npx mocha --require test/support/env test/res.set.js