fix(res): preserve original value when mime.contentType() returns false#7046
Closed
speedcoder430 wants to merge 1 commit intoexpressjs:masterfrom
Closed
fix(res): preserve original value when mime.contentType() returns false#7046speedcoder430 wants to merge 1 commit intoexpressjs:masterfrom
speedcoder430 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Contributor
|
Duplicate of #7035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: prevent
res.set('Content-Type')from setting header to literal string'false'When calling
res.set('Content-Type', value)with a value thatmime.contentType()cannot resolve (e.g.,'some-custom-type', it returns false. This false was passed directly tosetHeader(), which coerced it to the string"false"— resulting inContent-Type: falsein the response headers.This change falls back to the original value when
mime.contentType()returnsfalse, consistent with howres.type()already handles this case.Changes:
response.js:mime.contentType(value)→mime.contentType(value) || valueres.set.js: Added test to verify the original value is preserved for unrecognized typesFixes #7034