You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Clarifies the Quick Start note about express-generator versioning: the generator’s major version indicates which Express major it targets (implication, not equality). Also
updates the “Security Issues” link to the stable security policy URL: https://github.com/expressjs/express/security/policy
The express-generator part is still true - major version X of generator uses Express version X. There is no generator 5 that would install Express 5, but using any existing version of generator won't install it either. Think of it as an implication instead of equality.
The express-generator part is still true - major version X of generator uses Express version X. There is no generator 5 that would install Express 5, but using any existing version of generator won't install it either. Think of it as an implication instead of equality.
Good point — agreed (it’s an implication, not equality). I updated the wording to clarify that the generator’s major version indicates which Express major it targets, without implying that an Express major necessarily has a matching generator major.
Hi @krzysdz@efekrskl For now, just kept the security link Fix. Earlier it was broken and was not pointing to security docs. Removed the generator note to avoid confusion. Thanks for the review and your valuable time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
twoone README issue:Clarifies the Quick Start note about express-generator versioning: the generator’s major version indicates which Express major it targets (implication, not equality). Alsoupdates the “Security Issues” link to the stable security policy URL: https://github.com/expressjs/express/security/policy
Certificate of Origin
Signed-off-by: Pavan Shinde pavann97@gmail.com