fix(checker): detect $env() calls at compile time#923
Open
thevilledev wants to merge 1 commit intoexpr-lang:masterfrom
Open
fix(checker): detect $env() calls at compile time#923thevilledev wants to merge 1 commit intoexpr-lang:masterfrom
thevilledev wants to merge 1 commit intoexpr-lang:masterfrom
Conversation
Previously, expressions like `$env(abs())` would compile without error
and cause a runtime "stack underflow" panic. The checker now validates
that $env cannot be used as a function callee, producing a clear error
message like "map[string]interface {} is not callable".
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, expressions like
$env(abs())would compile without error and cause a runtime "stack underflow" panic. The checker now validates that $env cannot be used as a function callee, producing a clear error message like "map[string]interface {} is not callable".Maybe a more long-term fix would be to add an
EnvNodeAST type. Now$envis used here and there as-is.Relates to #922.