Skip to content

bin/verify-exercises-in-docker#455

Open
keiravillekode wants to merge 5 commits intoexercism:mainfrom
keiravillekode:verify-exercises-in-docker
Open

bin/verify-exercises-in-docker#455
keiravillekode wants to merge 5 commits intoexercism:mainfrom
keiravillekode:verify-exercises-in-docker

Conversation

@keiravillekode
Copy link
Copy Markdown
Contributor

This script provides a convenient way to test exercises against a test runner image.

verify_exercises() {
local -a exercises
local parent path
if (( $# )); then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern looks familiar to me 😆

Comment thread bin/verify-exercises-in-docker Outdated
Comment thread bin/verify-exercises-in-docker Outdated
command -v "${1}" >/dev/null 2>&1 || die "${1} is required but not installed. Please install it and make sure it's in your PATH."
}

copy_example_or_examplar_to_solution() {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
copy_example_or_examplar_to_solution() {
copy_example_or_exemplar_to_solution() {

@BNAndras BNAndras added x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) labels Apr 13, 2026
@keiravillekode
Copy link
Copy Markdown
Contributor Author

Taking out readlink, does the script now work with Apple-shipped bash?

@IsaacG
Copy link
Copy Markdown
Member

IsaacG commented Apr 13, 2026

Taking out readlink, does the script now work with Apple-shipped bash?

readlink isn't a bash tool; it's a separate standard utility :)

local slug="${1}" dir="${2}"
local -a docker_args

docker_args+=( --rm --network none )
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The += needs bash 3.1+
I think Mac uses 3.2

@IsaacG
Copy link
Copy Markdown
Member

IsaacG commented Apr 13, 2026

I think the tool(s) that tend to trip me up the most with needing bash4 is read -a/readarray/mapfile which isn't used here.

@keiravillekode
Copy link
Copy Markdown
Contributor Author

I don't have merge privileges.

@IsaacG
Copy link
Copy Markdown
Member

IsaacG commented Apr 14, 2026

@BNAndras should have merge access as a track maintainer

@BNAndras
Copy link
Copy Markdown
Member

Yeah, I’ll merge in a couple of days if the other maintainers don’t have feedback before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants