Skip to content

Conversation

@BethanyG
Copy link
Member

Forum Discussion.

Didn't add a whole lot here, but I hope it helps without confusing things.

@BethanyG
Copy link
Member Author

@ErikSchierboom -- ok to merge?

@chivalry
Copy link
Contributor

I think this does a nice job of, first, pointing out the trailing comma for the user, and second, pointing the user to more information if needed. tyvm, @BethanyG.

@ErikSchierboom
Copy link
Member

@ErikSchierboom -- ok to merge?

Looks good, but why are you asking me? :D

@BethanyG
Copy link
Member Author

BethanyG commented Nov 19, 2024

Apologies @ErikSchierboom ! I should have been clearer in my note. This was one of three PRs that tested your bot fix.

Rather than just doing test PRs, this one and PR 3825 are "live" changes. PR 3827 is test-only.

Just wondering when to merge/close and revert PR 3824.

@ErikSchierboom
Copy link
Member

@BethanyG I think the behavior is correct here! Thanks for the test!

As for the actual merging, feel free to do whatever you like :)

@BethanyG BethanyG merged commit be19148 into exercism:main Nov 19, 2024
10 checks passed
petrem pushed a commit to petrem/exercism--python that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants