feat: add Hungarian translations#936
Conversation
bsipocz
left a comment
There was a problem hiding this comment.
I have a bunch of suggestions, most of the translations look good, but one or two may be off depending on the context. Also, I think we should drop all the : to be more consistent with the other languages, and may also want to have everything capitalized? (I'm not sure about that one).
Also, unrelated nitpick: please don't mix new features with restructuring and other unrelated stylistic changes in the same commit or even in the same PR. It would have been easier to review without all the reordering.
src/sphinx_book_theme/assets/translations/jsons/open issue.json
Outdated
Show resolved
Hide resolved
src/sphinx_book_theme/assets/translations/jsons/Source repository.json
Outdated
Show resolved
Hide resolved
src/sphinx_book_theme/assets/translations/jsons/Sphinx Book Theme.json
Outdated
Show resolved
Hide resolved
|
So, can you accept this PR as is, or shall I modify it by adding Hungarian translations to the end of the list? |
|
You can insert the Hungarian into the roughly correct alphabetical location or to the end. The point is to not mix in unrelated reorganisations. If your editor reorders/restyles everything automatically, then you can selectively add only the Hungarian lines. Now it's already done and reviewed, so it's more about future open source contributions. |
|
I reverted the sorting. Now it contains only the new translations. |
bsipocz
left a comment
There was a problem hiding this comment.
some of the comments still stand
src/sphinx_book_theme/assets/translations/jsons/Sphinx Book Theme.json
Outdated
Show resolved
Hide resolved
src/sphinx_book_theme/assets/translations/jsons/Source repository.json
Outdated
Show resolved
Hide resolved
|
I applied your suggestions, but now it is inconsistent with the original string and other languages' translations. I ask you to also apply some changes in source string after you merge this PR:
|
Added Hungarian translations and sorted existing translations in alphabetical order.