Skip to content

feat: add Hungarian translations#936

Open
urbalazs wants to merge 4 commits intoexecutablebooks:mainfrom
urbalazs:hun-20260318
Open

feat: add Hungarian translations#936
urbalazs wants to merge 4 commits intoexecutablebooks:mainfrom
urbalazs:hun-20260318

Conversation

@urbalazs
Copy link
Copy Markdown

Added Hungarian translations and sorted existing translations in alphabetical order.

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bunch of suggestions, most of the translations look good, but one or two may be off depending on the context. Also, I think we should drop all the : to be more consistent with the other languages, and may also want to have everything capitalized? (I'm not sure about that one).

Also, unrelated nitpick: please don't mix new features with restructuring and other unrelated stylistic changes in the same commit or even in the same PR. It would have been easier to review without all the reordering.

@urbalazs
Copy link
Copy Markdown
Author

So, can you accept this PR as is, or shall I modify it by adding Hungarian translations to the end of the list?

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Mar 19, 2026

You can insert the Hungarian into the roughly correct alphabetical location or to the end. The point is to not mix in unrelated reorganisations.

If your editor reorders/restyles everything automatically, then you can selectively add only the Hungarian lines.

Now it's already done and reviewed, so it's more about future open source contributions.

@urbalazs
Copy link
Copy Markdown
Author

I reverted the sorting. Now it contains only the new translations.

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the comments still stand

@urbalazs
Copy link
Copy Markdown
Author

I applied your suggestions, but now it is inconsistent with the original string and other languages' translations.

I ask you to also apply some changes in source string after you merge this PR:

  • Sphinx Book Theme -> Sphinx Book Template
  • Source repository -> Source code repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants