Support building line blocks with markdown-it hardbreaks#948
Open
jdknight wants to merge 1 commit intoexecutablebooks:masterfrom
Open
Support building line blocks with markdown-it hardbreaks#948jdknight wants to merge 1 commit intoexecutablebooks:masterfrom
jdknight wants to merge 1 commit intoexecutablebooks:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #948 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 24 24
Lines 3418 3441 +23
=======================================
+ Hits 3081 3102 +21
- Misses 337 339 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jdknight
force-pushed
the
hardbreaks-into-lineblocks
branch
from
08f1afa to
d1990c5
Compare
Provides the ability to build docutils' line-block nodes if an inline element contains hardbreaks. When a hardbreak is detected as a child of an inline token, a line-block will be created and child tokens will be rendered into a prepared line node. Child nodes are placed into a line node until the next hardbreak is detected, where a new line node is created to hold the next child set. The process repeats until all children are processed. Signed-off-by: James Knight <git@jdknight.me>
jdknight
force-pushed
the
hardbreaks-into-lineblocks
branch
from
d1990c5 to
1873066
Compare
|
This PR would be super helpfull! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides the ability to build docutils' line-block nodes if an inline element contains hardbreaks. When a hardbreak is detected as a child of an inline token, a line-block will be created and child tokens will be rendered into a prepared line node. Child nodes are placed into a line node until the next hardbreak is detected, where a new line node is created to hold the next child set. The process repeats until all children are processed.
This change is in relation to #877. The change should allow any translator type to handle these line breaks, without requiring the raw directive.
With a document:
Example renderings:
(HTML)
(PDF)
(Confluence)
