Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces Oxlint and Oxfmt into the project's frontend workflow to improve code quality and formatting consistency. It updates configuration files, scripts, and dependencies to integrate these tools alongside existing linting and formatting solutions. The changes also adjust the ESLint and Vite configurations to support Oxlint, and update the
package.jsonto use the latestrolldown-vitebuild.Tooling and Linting Integration:
.oxlintrc.jsonand.oxfmtrc.jsonconfiguration files to define project-specific rules for Oxlint and Oxfmt. [1] [2]eslint.config.jsto includeeslint-plugin-oxlintand to load Oxlint configuration, ensuring ESLint rules do not overlap with Oxlint. [1] [2]vite-plugin-oxlintinto the Vite configuration, enabling Oxlint checks during the build process. [1] [2]Scripts and Dependency Updates:
package.jsonscripts to addlint:oxfmt,lint:oxlint, and corresponding format commands, and to ensure Oxlint and Oxfmt are run as part of the main linting and formatting workflows.eslint-plugin-oxlint,vite-plugin-oxlint,oxlint, andoxfmttodevDependencies.vitedependency to use the latestrolldown-vitebuild and updated theoverridessection accordingly.These changes help enforce stricter code standards and ensure a more consistent codebase by leveraging the latest linting and formatting tools.