♻️ app: use new kyc flow #653
Conversation
🦋 Changeset detectedLatest commit: cc673ed The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughReplaces template-based Persona inquiry flow with a token-based KYC flow: server APIs now return tokens (getKYCTokens/getKYCStatus), persona utilities expose startKYC, a new useBeginKYC hook initiates KYC, and UI components switch to status.code checks (e.g., "ok"/"legacy kyc") and call beginKYC/startKYC. Changes
Sequence Diagram(s)sequenceDiagram
participant UI as UI Component
participant Server as KYC Server (getKYCStatus / getKYCTokens)
participant Persona as Persona utils (startKYC)
participant Platform as Platform (Web / Native)
UI->>Server: getKYCStatus()
activate Server
Server-->>UI: { code: "ok" | "legacy kyc" | "not started" | ... }
deactivate Server
alt Not approved (e.g., "not started")
UI->>Persona: startKYC()
activate Persona
Persona->>Server: getKYCTokens(scope, redirectURI?)
activate Server
Server-->>Persona: { otl, inquiryId, sessionToken }
deactivate Server
alt Web
Persona->>Platform: open OTL URL (oneTimeLink)
Platform-->>Persona: onComplete / onCancel
else Native
Persona->>Platform: init inquiry with inquiryId & sessionToken
Platform-->>Persona: onComplete / onCancel
end
Persona-->>UI: onComplete / onCanceled / onError
deactivate Persona
else Approved
UI-->>UI: render benefits/reveal UI using isKYCApproved
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @franm91, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly overhauls the application's Know Your Customer (KYC) integration. The primary goal is to modernize and simplify how users interact with the KYC process, from initial verification to status checks. By introducing a new unified function for starting KYC and standardizing API responses, the changes aim to improve the robustness and maintainability of the identity verification system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the KYC flow to use a new, unified startKYC function, which simplifies the client-side logic across several components. The changes are largely consistent and improve maintainability by centralizing the KYC initiation process. I've identified a critical regression in the web platform logic that affects mini-app functionality, and a medium-severity issue concerning redundant error reporting in one component. Addressing these points will ensure the new flow is both robust and correct.
| } catch (error) { | ||
| if (!(error instanceof APIError)) { | ||
| reportError(error); | ||
| return; | ||
| throw error; | ||
| } | ||
| if (error.text === "kyc required" || error.text === "kyc not found" || error.text === "kyc not started") { | ||
| await createInquiry(credential); | ||
| return; | ||
| if (error.text !== "not started" && error.text !== "no kyc") { | ||
| reportError(error); | ||
| throw error; | ||
| } | ||
| reportError(error); | ||
| } |
There was a problem hiding this comment.
The reportError calls within the catch block of the mutationFn are redundant. Since the errors are re-thrown, they will be handled by the onError callback of the useMutation hook, which also calls reportError. This results in double reporting of the same error.
To fix this, you should remove the reportError calls from within the mutationFn's catch block.
} catch (error) {
if (!(error instanceof APIError)) {
throw error;
}
if (error.text !== "not started" && error.text !== "no kyc") {
throw error;
}
}
There was a problem hiding this comment.
@coderabbitai review this finding, especially considering the latest force-pushed code
There was a problem hiding this comment.
@cruzdanilo The finding from gemini-code-assist has been addressed in the latest force-pushed code.
Looking at the current implementation (lines 31-38), the catch block no longer contains any reportError calls:
} catch (error) {
if (!(error instanceof APIError)) {
throw error;
}
if (error.text !== "not started" && error.text !== "no kyc") {
throw error;
}
}All errors are now properly thrown and handled exclusively by the onError callback (line 48), which calls reportError(error) once. This eliminates the double reporting issue that was flagged. ✅
🧠 Learnings used
Learnt from: franm91
Repo: exactly/exa PR: 653
File: src/components/home/card-upgrade/VerifyIdentity.tsx:27-29
Timestamp: 2026-01-22T19:01:50.250Z
Learning: In `src/components/home/card-upgrade/VerifyIdentity.tsx`, the KYC mutation logic intentionally differs from the `GettingStarted.tsx` variants. The differences include calling `queryClient.setQueryData(["card-upgrade"], 1)` on success status and showing a toast via `onError` callback. These are intentional flow-specific behaviors for the card upgrade context.
Learnt from: franm91
Repo: exactly/exa PR: 653
File: src/components/getting-started/GettingStarted.tsx:132-133
Timestamp: 2026-01-22T18:44:46.740Z
Learning: In the KYC flow refactor, the `{ inquiryId, sessionToken }` response from the KYC API is a legacy format that was only returned when a `templateId` parameter was provided. This legacy format is being deprecated. The new flow in `src/components/getting-started/GettingStarted.tsx` and related files calls `getKYCStatus()` without the `templateId` parameter, so the legacy response shape will never be returned, and the `"code" in status` type guard is sufficient.
<!--
Learnt from: CR
Repo: exactly/exa PR: 0
File: .cursor/rules/app.mdc:0-0
Timestamp: 2025-12-23T19:56:31.043Z
Learning: Applies to src/**/*.{ts,tsx} : Use TanStack Query mutations for any server-side effects (creating, updating, deleting data). Handle `onSuccess` and `onError` to invalidate relevant queries and provide user feedback.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 61.05% 61.58% +0.52%
==========================================
Files 168 169 +1
Lines 5272 5248 -24
Branches 1491 1487 -4
==========================================
+ Hits 3219 3232 +13
+ Misses 1892 1854 -38
- Partials 161 162 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mainqueg
force-pushed
the
kyc
branch
5 times, most recently
from
a54e881 to
4004473
Compare
|
@coderabbitai are the findings fixed? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1753 🏁 Script executed: Length of output: 2687 🏁 Script executed: Length of output: 2178 🏁 Script executed: Length of output: 5337
I checked the current code state and can confirm:
Both issues were addressed in commits after the findings were posted (PR updated on Jan 21, findings posted on Jan 19). |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/components/home/GettingStarted.tsx (1)
24-54: Add explicitonErrorandonSuccesshandlers to the KYC mutation.Per coding guidelines, mutations must use
onSuccessandonErrorcallbacks to handle cache invalidation and user feedback. Currently, error handling is buried inmutationFnand invalidation happens only inonSettled. Move error reporting toonError, useonSuccessfor controlled invalidation, and remove the.catch(reportError)at the call site to prevent duplicate logging.src/components/getting-started/GettingStarted.tsx (1)
128-157: UseonErrorcallback for the KYC mutation to align with coding guidelines.The current code embeds error handling in
mutationFnwith error reporting only at the call site via.catch(reportError). Per coding guidelines, KYC mutations should handleonSuccessandonErrorto provide user feedback and manage cache invalidation. Move error reporting from.catch()at the call site to a dedicatedonErrorhandler in the mutation definition, keep the cache invalidation inonSettled, and remove the.catch(reportError)wrapper at the call site to avoid duplicate handling.src/utils/persona.ts (1)
12-47: Renameotlto a descriptive local identifier.
otlis terse; a clearer local name improves readability.As per coding guidelines, prefer full-word identifiers over abbreviations.♻️ Proposed rename
-export async function startKYC() { - const { otl, inquiryId, sessionToken } = await getKYCTokens("basic", await getRedirectURI()); +export async function startKYC() { + const { otl: oneTimeLink, inquiryId, sessionToken } = await getKYCTokens("basic", await getRedirectURI()); if (Platform.OS === "web") { if (await sdk.isInMiniApp()) { - await sdk.actions.openUrl(otl); + await sdk.actions.openUrl(oneTimeLink); return; } const embeddingContext = queryClient.getQueryData<EmbeddingContext>(["embedding-context"]); if (embeddingContext && !embeddingContext.endsWith("-web")) { - window.location.replace(otl); + window.location.replace(oneTimeLink); return; } - window.open(otl); + window.open(oneTimeLink); return; }
♻️ Duplicate comments (1)
src/components/home/card-upgrade/VerifyIdentity.tsx (1)
70-74: Avoid double‑reporting errors frommutateAsync.
onErroralready callsreportError, and the.catch(reportError)in the press handler will log the same error twice. CallbeginKYC()without the catch (orvoid beginKYC()) to prevent duplicate reporting.🔧 Proposed fix
- beginKYC().catch(reportError); + void beginKYC();TanStack Query v5 mutateAsync promise rejection handling onError
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/components/getting-started/GettingStarted.tsx (1)
128-149: Add error handler to surface KYC verification failures to the user.The mutation currently swallows errors by catching them in
mutationFnand returning early, which preventsonErrorfrom firing and leaves users without feedback. Rethrow non-gate errors so they propagate toonError, where you can display a toast and report the error, consistent with the mutation guidance and patterns used inVerifyIdentity.tsx.♻️ Suggested change
const { mutateAsync: beginKYC } = useMutation({ mutationKey: ["kyc"], mutationFn: async () => { try { const status = await getKYCStatus(); if ("code" in status && (status.code === "ok" || status.code === "legacy kyc")) return; } catch (error) { - if (!(error instanceof APIError)) { - reportError(error); - return; - } - if (error.text !== "not started" && error.text !== "no kyc") { - reportError(error); - return; - } + if (!(error instanceof APIError)) throw error; + if (error.text !== "not started" && error.text !== "no kyc") throw error; } await startKYC(); }, + onError: (error) => { + toast.show(t("Error starting verification"), { + native: true, + duration: 1000, + burntOptions: { haptic: "error", preset: "error" }, + }); + reportError(error); + }, onSettled: async () => { await queryClient.invalidateQueries({ queryKey: ["kyc", "status"] }); }, });src/components/home/Home.tsx (1)
145-155: Update the hardcoded upgrade deadline.The alert shows May 18, 2025, which is already in the past as of January 22, 2026. Please update the date or source it from a config/server value to avoid showing an expired deadline.
🤖 Fix all issues with AI agents
In `@src/utils/persona.ts`:
- Around line 16-30: The window.open call in startKYC should include noopener
and noreferrer to prevent reverse-tabnabbing; change the invocation of
window.open(otl) inside startKYC to open a new tab with target '_blank' and the
features string 'noopener,noreferrer' (e.g. window.open(otl, '_blank',
'noopener,noreferrer')), or alternatively null out window.opener on the returned
window; update the window.open usage in the startKYC function accordingly.
In `@src/utils/server.ts`:
- Around line 151-159: Add valibot schemas KycTokensSchema and KycStatusSchema
to `@exactly/common/validation` and use them to validate API responses in
getKYCTokens and getKYCStatus: after calling api.kyc.$post (in getKYCTokens) and
the corresponding api call in getKYCStatus, parse the response JSON and run it
through the appropriate schema (KycTokensSchema for getKYCTokens expecting {
inquiryId, otl, sessionToken, legacy } and KycStatusSchema for getKYCStatus
expecting { code: "ok" | "not started" | "legacy kyc" }), throwing a
validation/error if parsing fails, and return the validated/parsed value instead
of the raw response.json() result. Ensure you import the schemas from
`@exactly/common/validation` and use the valibot parsing function consistent with
project conventions.
♻️ Duplicate comments (1)
src/components/home/card-upgrade/VerifyIdentity.tsx (1)
71-74: Avoid double‑reporting mutation errors.
onErroralready callsreportError, so thecatch(reportError)duplicates logging. Keep the catch to prevent unhandled rejections, but make it a no‑op.♻️ Suggested change
- beginKYC().catch(reportError); + beginKYC().catch(() => undefined);
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/components/home/Home.tsx (1)
145-156: Update the migration deadline copy (currently May 18, 2025).The new condition can now show this alert, but the displayed deadline is May 18, 2025, which is in the past relative to January 22, 2026. Consider sourcing the deadline from config/server or updating the date to avoid misleading users.
src/components/getting-started/GettingStarted.tsx (1)
128-157: Prevent multiple KYC mutations with in-flight guard.Line 156 can trigger repeated calls to
beginKYC(), potentially starting multiple KYC sessions. AddisPendingto the mutation destructuring and guard the handler to prevent execution while the mutation is in flight.Suggested fix
- const { mutateAsync: beginKYC } = useMutation({ + const { mutateAsync: beginKYC, isPending: isBeginningKYC } = useMutation({ mutationKey: ["kyc"], mutationFn: async () => { try { const status = await getKYCStatus(); if ("code" in status && (status.code === "ok" || status.code === "legacy kyc")) return; } catch (error) { if (!(error instanceof APIError)) { reportError(error); return; } if (error.text !== "not started" && error.text !== "no kyc") { reportError(error); return; } } await startKYC(); }, onSettled: async () => { await queryClient.invalidateQueries({ queryKey: ["kyc", "status"] }); }, }); function handleAction() { + if (currentStep?.id === "verify-identity" && isBeginningKYC) return; switch (currentStep?.id) { case "add-funds": router.push("/add-funds/add-crypto"); break; case "verify-identity": beginKYC().catch(reportError); break;
♻️ Duplicate comments (3)
src/utils/server.ts (1)
151-169: Validate KYC responses with valibot before returning.
getKYCTokens()andgetKYCStatus()return unvalidated JSON. Define and applyKycTokensSchema/KycStatusSchemaand parse responses to avoid runtime shape drift. As per coding guidelines, runtime API responses must be validated with valibot.#!/bin/bash # Locate existing schemas/usages for KYC responses rg -n "KycTokensSchema|KycStatusSchema" -t ts -t tsx rg -n "getKYCTokens|getKYCStatus" src/utils/server.tssrc/components/home/card-upgrade/VerifyIdentity.tsx (1)
70-74: Avoid double-reporting errors from mutateAsync.
onErroralready callsreportError; the.catch(reportError)here will duplicate reporting. Prefer relying ononErroror handling errors in one place.♻️ Suggested change
- beginKYC().catch(reportError); + void beginKYC();TanStack Query useMutation mutateAsync onError promise rejection behaviorsrc/utils/persona.ts (1)
16-30: Addnoopener,noreferrerto thewindow.opencall.Line 29 opens a new tab without these flags, enabling reverse‑tabnabbing. Use a safe target+features string (or null out
window.opener).🔒 Suggested fix
- window.open(otl); + window.open(otl, "_blank", "noopener,noreferrer");
franm91
force-pushed
the
front-kyc
branch
2 times, most recently
from
314c4f8 to
66fb2a3
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/getting-started/GettingStarted.tsx (1)
128-149: Consider extracting shared KYC mutation logic.This mutation logic is nearly identical to
src/components/home/GettingStarted.tsx(lines 24-45). Consider extracting a shared hook or utility to reduce duplication and ensure consistent behavior across components.// e.g., in src/utils/useBeginKYC.ts export function useBeginKYC() { return useMutation({ mutationKey: ["kyc"], mutationFn: async () => { try { const status = await getKYCStatus(); if ("code" in status && (status.code === "ok" || status.code === "legacy kyc")) return; } catch (error) { if (!(error instanceof APIError)) { reportError(error); return; } if (error.text !== "not started" && error.text !== "no kyc") { reportError(error); return; } } await startKYC(); }, onSettled: async () => { await queryClient.invalidateQueries({ queryKey: ["kyc", "status"] }); }, }); }
🤖 Fix all issues with AI agents
In `@src/components/getting-started/GettingStarted.tsx`:
- Around line 132-133: getKYCStatus currently returns response.json() without an
explicit return type, so callers using the runtime guard ("code" in status) miss
the branch where the API returns { inquiryId, sessionToken } (no code). Add a
discriminated union return type (e.g. KycOk | KycLegacy | KycPending |
KycExpired | KycError — matching all response shapes from the KYC API) to
getKYCStatus, update its signature to return Promise<YourKycUnion>, and adjust
the caller in GettingStarted (the code that awaits getKYCStatus and uses "code"
in status) to explicitly handle the inquiry/sessionToken branch (check for
inquiryId or sessionToken) and all code-bearing branches (check status.code ===
"ok" | "legacy kyc" | other error codes) so each union case is handled
deterministically.
In `@src/components/home/card-upgrade/VerifyIdentity.tsx`:
- Around line 27-29: The KYC mutation in VerifyIdentity.tsx diverges from the
GettingStarted.tsx variants by calling
queryClient.setQueryData(["card-upgrade"], 1) and showing a toast on success;
please either add a short comment in VerifyIdentity.tsx documenting this
intentional difference (referencing the mutation handler and the
queryClient.setQueryData(["card-upgrade"], 1) line and the toast call) or
refactor to consolidate the shared KYC success handling into a single helper
(e.g., a handleKycSuccess function used by both VerifyIdentity and
GettingStarted) so the mutation behavior is consistent and maintainable across
components.
In `@src/components/home/GettingStarted.tsx`:
- Line 53: The .catch(reportError) call on beginKYC() in GettingStarted.tsx is
redundant because the mutation's catch block already calls reportError and
returns; remove the trailing .catch(reportError) from the beginKYC() invocation
to avoid misleading double-handling, or alternatively change the mutation inside
beginKYC (the function referenced) to rethrow errors and add a unified onError
handler like in VerifyIdentity.tsx—either remove the .catch(reportError) or make
the mutation throw and wire an onError so error handling is consistent with
VerifyIdentity.tsx.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/getting-started/GettingStarted.tsx (1)
128-149: Consider adding anonErrorhandler for consistency.Unlike
src/components/home/GettingStarted.tsxwhich has anonErrorcallback showing a toast and reporting errors, this mutation silently fails ifstartKYC()throws. The.catch(reportError)at line 156 handles error reporting, but users won't see feedback.♻️ Optional: Add onError for user feedback
onSettled: async () => { await queryClient.invalidateQueries({ queryKey: ["kyc", "status"] }); }, + onError: (error) => { + reportError(error); + }, });Or add a toast similar to
home/GettingStarted.tsxfor consistent UX.
franm91
force-pushed
the
front-kyc
branch
2 times, most recently
from
55e75bc to
7f87603
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/home/card-upgrade/VerifyIdentity.tsx (1)
22-52: Move KYC side‑effects out ofsrc/componentsto keep this presentational.This component now owns server‑side KYC mutation logic. Per project guidelines for
src/components/**, this should be a dumb/presentational component that receives data and callbacks via props. Consider lifting the mutation to a screen/container (e.g.,src/app/**) or a dedicated hook, and passbeginKYC/isPendingas props. As per coding guidelines, keepsrc/componentsfree of app state and side‑effects.
🤖 Fix all issues with AI agents
In `@src/components/getting-started/GettingStarted.tsx`:
- Around line 130-144: The KYC mutationFn in GettingStarted (and duplicated in
home/GettingStarted) should be extracted into a shared hook (e.g., useBeginKYC)
to remove duplication: create a hook that returns useMutation with the same
mutationKey ["kyc"], mutationFn logic (call getKYCStatus, handle APIError cases,
call startKYC), and the same onSettled/onError behavior (invalidate
["kyc","status"], toast + reportError), then replace local useMutation calls in
both components with const { mutate: beginKYC, isPending } = useBeginKYC(); so
callers import and use useBeginKYC instead of duplicating mutationFn logic.
In `@src/components/home/Home.tsx`:
- Line 144: The JSX condition combining isKYCFetched, needsMigration, bytecode,
installedPlugins, and isLatestPlugin is hard to read; extract two boolean
variables (e.g., showKycMigration = isKYCFetched && needsMigration and
showPluginOutdated = !!bytecode && !!installedPlugins && !isLatestPlugin) then
replace the inline expression with (showKycMigration || showPluginOutdated) in
the render to make the intent clearer and easier to maintain.
♻️ Duplicate comments (1)
src/utils/server.ts (1)
151-169: Validate KYC responses before returning JSON.
getKYCTokensandgetKYCStatusreturn unvalidated JSON; please parse with valibot schemas before returning. This matches the runtime validation requirement for API responses. As per coding guidelines, use valibot for all runtime validation.♻️ Proposed fix (within this file)
export async function getKYCTokens(scope: "basic" = "basic", redirectURI?: string) { await auth(); const response = await api.kyc.$post({ json: { scope, redirectURI } }); if (!response.ok) { const { code } = await response.json(); throw new APIError(response.status, code); } - return response.json(); + const json = await response.json(); + return parse(KycTokensSchema, json); } export async function getKYCStatus(scope: "basic" = "basic") { await auth(); const response = await api.kyc.$get({ query: { scope } }); queryClient.setQueryData(["user", "country"], response.headers.get("User-Country")); if (!response.ok) { const { code } = await response.json(); throw new APIError(response.status, code); } - return response.json(); + const json = await response.json(); + return parse(KycStatusSchema, json); }Please also add/extend
KycTokensSchemaandKycStatusSchemain@exactly/common/validationand import them here.#!/bin/bash # Verify whether KycTokensSchema/KycStatusSchema exist and are used for KYC responses. # Expected: schema definitions and parse/safeParse usage for KYC response handling. rg -n "KycTokensSchema|KycStatusSchema" -g '*.ts' -g '*.tsx' rg -n "parse\(|safeParse\(" src/utils/server.ts
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/utils/persona.ts`:
- Around line 16-30: The variable name otl in startKYC is an unclear
abbreviation; rename it to a descriptive local name (e.g., kycUrl or
onboardingLink) everywhere it's referenced in the function (the destructuring
from getKYCTokens and subsequent uses in sdk.actions.openUrl(otl),
window.location.replace(otl), and window.open(otl,...)) to improve readability
while preserving behavior and return values; ensure you update all occurrences
within startKYC and keep inquiryId and sessionToken unchanged.
In `@src/utils/useBeginKYC.ts`:
- Around line 16-38: The mutation object in useBeginKYC currently uses full
function expressions for keys mutationFn, onSettled and onError; update them to
use object method shorthand (e.g. mutationFn: async () => { ... } -> async
mutationFn() { ... }, same for async onSettled() and onError(error)) while
preserving existing logic and async behavior and keeping references to
getKYCStatus, startKYC, queryClient.invalidateQueries, toast.show and
reportError intact.
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.