Add documentation on Binaryen and Wabt #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugo-dc
changed the title
lrettig
reviewed
Dec 14, 2018
Member
lrettig
left a comment
lrettig
left a comment
There was a problem hiding this comment.
Thanks @hugo-dc. A couple of high-level questions:
- Is this linked into the main README doc anywhere?
- Do you think it would be possible to add a little info at the beginning of this doc discussing the differences between binaryen and wabt? E.g., why do we need two of them? Is there some benefit to one over the other?
lrettig
requested changes
Dec 14, 2018
Member
lrettig
left a comment
lrettig
left a comment
There was a problem hiding this comment.
Made a few small tweaks and some suggestions. Thanks Hugo!
Member
|
Instructions on installing |
Member
Author
|
@lrettig Thanks a lot for reviewing and improving the document!, I have made some changes according to your comments. |
added 3 commits
December 15, 2018 15:05
Move into the "smart contracts" section
lrettig
requested changes
Dec 15, 2018
Member
lrettig
left a comment
lrettig
left a comment
There was a problem hiding this comment.
Just one final clarification! Thanks
Open
Change capitalization, reformat slightly, add a link
lrettig
approved these changes
Dec 27, 2018
Member
|
Thanks @hugo-dc! Made a few final tweaks, have a look. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#136