Skip to content

chore: Disable default features on some crates to unblock SP1 work #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonas089 wants to merge 6 commits into
base: main
Choose a base branch
from
+22 −25
Open

chore: Disable default features on some crates to unblock SP1 work #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bcc3057
feature gate kzg
jonas089 Jan 14, 2026
44df302
wip
jonas089 Jan 14, 2026
b0e1aff
wip
jonas089 Jan 14, 2026
f78b503
use alloy
jonas089 Jan 14, 2026
c1641fa
wip
jonas089 Jan 14, 2026
cb2f734
update to 1.8.4
jonas089 Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 20 additions & 21 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
resolver = "2"
members = [
"bin/ev-reth",
"crates/common",
"crates/evolve",
"crates/node",
"crates/tests",
"crates/ev-precompiles",
"crates/ev-revm",
"crates/common",
"crates/evolve",
"crates/node",
"crates/tests",
"crates/ev-precompiles",
"crates/ev-revm",
]

[workspace.package]
Expand Down Expand Up @@ -43,7 +43,7 @@ reth-primitives-traits = { git = "https://github.com/paradigmxyz/reth.git", tag
reth-provider = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-storage-api = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-tracing = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-transaction-pool = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-transaction-pool = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4", default-features = false }
reth-network = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-network-types = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-chain-state = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
Expand All @@ -54,18 +54,18 @@ reth-engine-local = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1
reth-engine-primitives = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-ethereum-payload-builder = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-ethereum-primitives = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-e2e-test-utils = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-evm = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-evm-ethereum = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-e2e-test-utils = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4", default-features = false }
reth-evm = { git = "https://github.com/paradigmxyz/reth.git", default-features = false, tag = "v1.8.4" }
reth-evm-ethereum = { git = "https://github.com/paradigmxyz/reth.git", default-features = false, tag = "v1.8.4" }
reth-execution-types = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-node-core = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-node-types = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-payload-builder = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-payload-builder-primitives = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-payload-primitives = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-primitives = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-primitives = { git = "https://github.com/paradigmxyz/reth.git", default-features = false, tag = "v1.8.4" }
Copy link
Contributor

@randygrok randygrok Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be changed in #103, will it cause problems back?

reth-ethereum-forks = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-revm = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-revm = { git = "https://github.com/paradigmxyz/reth.git", default-features = false, tag = "v1.8.4" }
reth-rpc-api = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-rpc-builder = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
reth-rpc-engine-api = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" }
Expand All @@ -86,14 +86,11 @@ reth-tasks = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4",
revm = { version = "29.0.1", default-features = false }
revm-context-interface = { version = "10.2.0", default-features = false }

# Alloy dependencies
alloy = { version = "1.0.37", features = [
alloy = { version = "=1.0.37", default-features = false, features = [
"contract",
"providers",
"provider-http",
"signers",
"reqwest-rustls-tls",
], default-features = false }
"sol-types",
] }
Comment on lines +89 to +92
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The alloy dependency's feature set has been significantly reduced from ["contract", "providers", "provider-http", "signers", "reqwest-rustls-tls"] to ["contract", "sol-types"]. While this aligns with the goal of removing C-dependencies, please ensure that the removed features (especially providers, provider-http, and signers) are not implicitly relied upon by other parts of the evolve code within the SP1 context. If any functionality is missing, it might lead to runtime errors or unexpected behavior.

# Alloy dependencies
# Alloy family versions aligned to 1.0.37 compatibility (reth v1.8.4)
alloy-evm = { version = "0.21.3", default-features = false }
alloy-eips = { version = "1.0.37", default-features = false }
Expand All @@ -112,12 +109,14 @@ alloy-genesis = { version = "1.0.37", default-features = false }
alloy-rpc-types-txpool = { version = "1.0.37", default-features = false }
alloy-sol-types = { version = "1.3.1", default-features = false }

revm-inspector = { version = "10.0.1" }
revm-inspector = { version = "10.0.1", default-features = false }
# Core dependencies
eyre = "0.6"
tracing = "0.1"
tokio = { version = "1.38", features = ["full"] }
serde = { version = "=1.0.228", default-features = false, features = ["derive"] }
serde = { version = "=1.0.228", default-features = false, features = [
"derive",
] }
serde_json = "1.0"
thiserror = "2.0"
async-trait = "0.1"
Expand Down