chore: add onboarding skill

[tac0turtle]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Performance improvement
• Refactoring

Related Issues

Fixes #(issue)

Checklist

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published

Testing

Additional Notes

[claude]

Claude finished @tac0turtle's task —— View job

---

Claude Code PR Review

Reviewing this PR that adds Claude Code skills documentation and workflow automation.

Todo List

• Review skill documentation files for accuracy
• Analyze GitHub workflow for security and best practices
• Check submodule changes
• Verify documentation aligns with codebase
• Provide comprehensive feedback

Skills Documentation Review

The skills documentation appears well-structured and accurate based on verification against file references:

✅ Good practices:

• Clear section organization with frontmatter descriptions
• Accurate file path references (verified against codebase)
• Good balance of overview vs. detail
• Helpful code snippets and exploration starting points
• Consistent formatting across all skills

⚠️ Minor observations:

• Line numbers in code examples (e.g., factory.rs:103-108) may become outdated as code evolves
• Some skills reference many files that could benefit from prioritization for new contributors

Workflow Security Analysis

✅ Security best practices followed:

• Uses pinned action versions (actions/checkout@v4)
• Minimal permissions (contents: write, pull-requests: write)
• Uses GitHub token correctly without exposure
• Safe shell scripting with proper quoting
• Uses heredoc for PR body generation to avoid injection
• File path filtering excludes sensitive areas
• No arbitrary code execution from user input

✅ Workflow logic is sound:

• Intelligently detects changes by area using git operations
• Handles existing PR updates vs. new PR creation
• Good error handling for edge cases
• Reasonable scheduling (weekly on Fridays)

Changes Analysis

Submodule Update: The forge-std submodule was updated (commit a220276), which is a standard dependency update for Foundry development.

Documentation Accuracy: Verified key file references and code snippets:

• ✅ EvolvePayloadBuilder structure matches documentation
• ✅ EvolvePayloadAttributes fields align with skill descriptions
• ✅ File paths and line number ranges are currently accurate

Overall Assessment

✅ Excellent PR - This adds valuable onboarding documentation with automated maintenance. The skills are accurate, well-structured, and will significantly help new contributors navigate the codebase.

Recommendations:

1. Consider adding versioning strategy for line number references
2. The workflow automation ensures skills stay up-to-date as code evolves

No security concerns, no bugs identified, good performance practices followed.

---