Skip to content

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 27, 2026

Overview

bump to core rc.1

@github-actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJan 27, 2026, 1:40 PM

@claude
Copy link
Contributor

claude bot commented Jan 27, 2026

Claude finished @julienrbrt's task in 2m 4s —— View job


Code Review Complete ✓


Summary

This PR bumps github.com/evstack/ev-node/core from v1.0.0-beta.5 to v1.0.0-rc.1 across multiple modules and cleans up unnecessary replace directives. The changes are focused on dependency management in a multi-module Go workspace.

Positive Observations

  1. Consistent version bump: The core dependency is correctly updated from v1.0.0-beta.5 to v1.0.0-rc.1 across all modified modules
  2. Clean refactoring: Removal of redundant replace github.com/evstack/ev-node/core => ../../core directives is a positive change, as these are unnecessary when the core module is already replaced via the parent module
  3. Proper go.sum updates: All go.sum files are updated accordingly with the new version hashes
  4. CI checks passing: Buf checks, Semantic PR checks, and Housekeeping workflows have passed

Critical Issues

1. Incomplete Dependency Update (High Priority)

Two go.mod files were not updated and still reference the old version v1.0.0-beta.5:

  • go.mod:15 (root module):

    github.com/evstack/ev-node/core v1.0.0-beta.5

    Fix this →

  • test/docker-e2e/go.mod:32 (indirect dependency):

    github.com/evstack/ev-node/core v1.0.0-beta.5 // indirect

    Fix this →

Impact: This creates version inconsistency across the workspace. While the replace directive in the root go.mod (github.com/evstack/ev-node/core => ./core) ensures the local core module is used during development, the version declaration should still be consistent for proper release builds and external consumers.

Recommendation: Update both files to reference v1.0.0-rc.1 and run go mod tidy in those directories.

2. Go Version Inconsistency in Core Module

The core/go.mod uses go 1.24.1 while all other modules use go 1.25.0:

// core/go.mod:3
go 1.24.1

Recommendation: For consistency and to avoid potential toolchain issues, consider updating core to go 1.25.0 or document why core needs an older Go version. Since core is meant to be a zero-dependency package (as noted in core/go.mod:5), this version difference may be intentional for broader compatibility.

Minor Observations

  1. Modified files count: The PR description states 12 files changed, which matches the actual changes (7 go.mod + 5 go.sum files, but execution/evm/test/go.mod makes 8 go.mod files modified)

  2. Replace directive cleanup: The removal of per-module core replace directives is correct since the root module already handles this via workspace mode

  3. CI status: Main CI and PR workflows are still in progress. The review should ideally wait for these to complete before merging

Code Quality Assessment (per review criteria)

Architecture & Dependency Management

  • ✅ Modular structure maintained with proper module boundaries
  • ⚠️ Inconsistent core version references across workspace (needs fix)
  • ✅ Replace directives properly simplified

Error Handling & Resilience

  • N/A (no code logic changes)

Security

  • ✅ No security concerns with dependency bumps
  • ✅ No credentials or secrets exposed

Performance & Resource Efficiency

  • N/A (dependency updates should not impact performance directly)

Testing & Reliability

  • ⏳ CI tests still in progress
  • ⚠️ Should verify all tests pass before merge

Documentation & Developer Experience

  • ⚠️ PR description is minimal ("bump to core rc.1") - consider adding:
    • What changed in core between beta.5 and rc.1
    • Any breaking changes or migration notes
    • Whether dependent modules need updates

Recommendations

  1. Fix the two missing go.mod updates in root and test/docker-e2e (critical)
  2. Run make test and make lint to ensure no breaking changes
  3. Consider running go work sync if using Go workspaces to ensure all modules are aligned
  4. Wait for CI to complete before merging
  5. Document breaking changes if any exist in the rc.1 release

Testing Checklist

Before merging, verify:

  • Root module go.mod updated to v1.0.0-rc.1
  • test/docker-e2e/go.mod updated to v1.0.0-rc.1
  • All CI checks pass (currently in progress)
  • make test passes locally
  • make lint passes locally
  • No breaking changes, or migration guide provided

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the core module dependency, github.com/evstack/ev-node/core, to its latest release candidate version, v1.0.0-rc.1. This ensures that all dependent applications and execution modules are aligned with the most recent pre-release of the core library, improving consistency and preparing the codebase for a stable v1.0.0 release. The change also streamlines module management by removing outdated local replace directives.

Highlights

  • Dependency Version Bump: The github.com/evstack/ev-node/core dependency has been updated from v1.0.0-beta.5 to v1.0.0-rc.1 across all affected modules.
  • Go Module Replace Directives: Explicit replace directives for github.com/evstack/ev-node/core pointing to local paths have been removed or simplified in several go.mod files, indicating a shift towards treating it as a standard module dependency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.91%. Comparing base (2325ace) to head (328f50a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3018      +/-   ##
==========================================
- Coverage   57.98%   57.91%   -0.07%     
==========================================
  Files         110      110              
  Lines       10522    10522              
==========================================
- Hits         6101     6094       -7     
- Misses       3770     3777       +7     
  Partials      651      651              
Flag Coverage Δ
combined 57.91% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the ev-node/core dependency to version 1.0.0-rc.1 across multiple go.mod files in the repository. It also removes an unnecessary replace directive in apps/evm/go.mod and execution/evm/go.mod. The changes look straightforward and necessary for updating the project's core dependency.

I am having trouble creating individual review comments. Click here to see my feedback.

apps/evm/go.mod (7)

medium

This replace directive is no longer needed and can be removed to simplify the module definition. Removing unnecessary directives improves maintainability.

apps/testapp/go.mod (5)

medium

This replace directive is more concise and readable than the previous block. This improves the overall clarity of the module definition.

execution/evm/go.mod (109-110)

medium

This replace directive is no longer needed and can be removed to simplify the module definition. Removing unnecessary directives improves maintainability.

@julienrbrt julienrbrt enabled auto-merge January 27, 2026 14:44
@julienrbrt julienrbrt added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit 62c9339 Jan 27, 2026
32 checks passed
@julienrbrt julienrbrt deleted the julien/bump-core branch January 27, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants