-
Notifications
You must be signed in to change notification settings - Fork 247
Fix: blog 404 #3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: blog 404 #3013
Conversation
The Blog section in the sidebar referenced /blog/overview but the blog directory was never created. Comment out the sidebar entry to match the already-commented nav entry. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
|
Claude finished @tac0turtle's task in 1m 11s —— View job Code Review Complete ✅Tasks
SummaryThis PR appropriately fixes a 404 error by commenting out the Blog section in the sidebar navigation. The change is consistent with the already-commented Blog entry in the main nav bar. Review Findings✅ Positives
Observations & SuggestionsTypeScript/Configuration Quality
Potential Future Considerations (not blocking)
Code Style
Recommendation✅ APPROVED - This PR is ready to merge. The fix is correct, minimal, and solves the stated problem effectively. |
Summary of ChangesHello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the interaction between the sequencer and execution layers by introducing explicit transaction filtering capabilities and a mechanism to query execution parameters. These changes improve the robustness of transaction processing, particularly for transactions originating from untrusted sources, and enhance the flexibility of sequencers in constructing blocks while maintaining proper state and crash recovery. The updates span the core execution interface, sequencer logic, and various executor implementations, ensuring a more coherent and extensible design. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant enhancements to the execution layer and sequencer logic, primarily by integrating new transaction filtering capabilities. The Executor interface has been extended with GetExecutionInfo and FilterTxs methods, allowing execution clients to provide gas limits and perform detailed transaction validation (including size and gas filtering) for force-included transactions. The maxBytes return value has been removed from InitChain and ExecuteTxs across the codebase, as this information is now retrieved via GetExecutionInfo.
Both BasedSequencer and SingleSequencer implementations have been updated to leverage these new filtering mechanisms, ensuring that only valid and appropriately sized/gassed transactions are processed. The BasedSequencer's checkpointing and crash recovery logic has been refined to correctly handle postponed transactions and resume processing from the exact point of interruption within an epoch. Comprehensive test cases have been added or updated to validate these new behaviors, including scenarios for gas filtering, error handling, and crash recovery.
The changes are consistently applied across various components, including command-line applications, gRPC clients/servers, and telemetry tracing. The documentation in CHANGELOG.md and pkg/sequencers/based/README.md has also been updated to reflect these architectural shifts and new functionalities.
Overview