fix: link CoreGraphics framework for Metal device detection#78
Open
aupadhyay wants to merge 1 commit intoevilsocket:mainfrom
Open
fix: link CoreGraphics framework for Metal device detection#78aupadhyay wants to merge 1 commit intoevilsocket:mainfrom
aupadhyay wants to merge 1 commit intoevilsocket:mainfrom
Conversation
MTLCreateSystemDefaultDevice() returns None when CoreGraphics is not linked, causing a panic (swap_remove on empty vec) during Metal device initialization. This affects fresh clones on macOS where nothing else pulls in CoreGraphics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cake chatpanics on a fresh macOS clone with--features metal:Fix
The call chain leads us to
candle_coreandcandle-metal-kernelslines 50-55 which callsMTLCreateSystemDefaultDevice()and collects into a Vec.MTLCreateSystemDefaultDevice()returnsNonebecause CoreGraphics is not linked. Documented requirement inobjc2-metal(see objc2-metal/src/lib.rs lines 14-16):candle-metal-kernelsdoesn't add this linkage, and neither does cakeOne line fix in
cake-core/build.rsVerified chat works on metal after fix