ci: forbid GitHub code scanning uploads#122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/code-scanning/sarifs,upload-sarif, andsecurity-events: writeWhy
EvalOps does not use CodeQL or GitHub Code Scanning. The prior guardrail caught CodeQL workflows, but deploy and keep still had SARIF upload paths into GitHub Code Scanning. This closes that recurrence path.
Rollback
Revert this PR to restore the narrower CodeQL-only workflow audit.
Test Plan
ruby -Itest test/audit_engineering_practices_test.rbruby -Itest -e 'Dir["test/*_test.rb"].sort.each { |path| load path }'git diff --checkDependency
This guardrail is expected to go green after evalops/deploy#4167 and evalops/keep#83 remove the existing Code Scanning upload surfaces from default branches.