fix(fsm): wake vehicle from offline/asleep when signals arrive#54
Open
atulmgupta wants to merge 2 commits into
Open
fix(fsm): wake vehicle from offline/asleep when signals arrive#54atulmgupta wants to merge 2 commits into
atulmgupta wants to merge 2 commits into
Conversation
HandleSignalReceived was defined but never called from the telemetry pipeline. When a vehicle went offline (e.g., telemetry disconnected) and signals resumed, DetectTriggers only checks for Gear/Charge/Speed triggers — none of which fire TriggerSignalReceived. The vehicle stayed stuck in offline even with active telemetry. Fix: call HandleSignalReceived at the start of ProcessSignals when the vehicle is in asleep or offline state. This transitions to online first, then ProcessSignals detects the actual state (charging, etc). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HandleSignalReceived was defined but never called from the telemetry pipeline. When a vehicle went offline (e.g., telemetry disconnected) and signals resumed, DetectTriggers only checks for Gear/Charge/Speed triggers — none of which fire TriggerSignalReceived. The vehicle stayed stuck in offline even with active telemetry.
Fix: call HandleSignalReceived at the start of ProcessSignals when the vehicle is in asleep or offline state. This transitions to online first, then ProcessSignals detects the actual state (charging, etc).
Description
Closes #
Type of Change
Checklist
Screenshots (if applicable)