Skip to content

Conversation

@nicoabie
Copy link
Contributor

fixes #323

@eugef eugef requested a review from Copilot November 4, 2025 10:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds type annotations to the _getJSONData method, specifically focusing on improving type safety for Express response objects with generic type parameters. The changes introduce test cases to verify proper typing behavior when using Express responses with custom data structures.

  • Adds type tests for Express responses with generic type parameters
  • Validates type safety for createResponse and createMocks functions with typed responses

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eugef
Copy link
Owner

eugef commented Nov 4, 2025

Hi @nicoabie thanks for your PR.

I want to make sure this change doesn’t require updating any existing tests that depend on the any type of _getJSONData. Is that correct?

@nicoabie
Copy link
Contributor Author

nicoabie commented Nov 4, 2025

Hi @nicoabie thanks for your PR.

I want to make sure this change doesn’t require updating any existing tests that depend on the any type of _getJSONData. Is that correct?

Yes, no need to change any existing tests, it uses any if no type is specified and specification is optional.

@eugef eugef merged commit f678068 into eugef:master Nov 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typing for _getJSONData

2 participants