fix(mockResponse): writeHead() sets headersSent
#313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
changed the title
writeHead() sets headersSent
Contributor
Author
|
@eugef , please review |
Contributor
Author
|
For the context: I'm implementing an event streaming response and headers are sent before body to an alive kept connection. |
Owner
|
Hi @RobinTail, thanks for PR. |
eugef
approved these changes
Dec 9, 2024
Contributor
Author
|
May I ask you to publish the patch, @eugef ? |
Owner
|
Sure, new release |
Contributor
Author
|
I'm not sure why, @eugef , but it's not really published.
|
Contributor
Author
|
Perhaps there was an error, like expired NPM token or something similar? |
Owner
|
Ah. my bad, forgot to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
According to documentation and my debugging findings
writeHead():Meaning that it does actually set
headersSentproperty totrue.This PR implements it and updates the test having wrong implication.