allowing Configuration to use a pydantic class type instead of instance#963
Open
warmagedon007 wants to merge 2 commits into
Open
allowing Configuration to use a pydantic class type instead of instance#963warmagedon007 wants to merge 2 commits into
warmagedon007 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the error on loading and passing a
pydantic.BaseSettingstype whenfrom_pydanticis called.Instead, an instance will be directly initialized (with no kwargs) for use in the loading process.
The purpose of this and to allow declaration and import of a declarative container before all setting are initialized (via envvars, files, etc), especially in tests.
A little note.
kwargs that are used now in the
Configurationare for passing kwargs for the pydanticdictormodel_dump. I thought it will be too confusing to change it to be also kwargs for the pydantic model initialization.