fix: remove double percentage multiplication in dora overview display#97
Open
fix: remove double percentage multiplication in dora overview display#97
Conversation
The Dora epoch API returns `globalparticipationrate` as an integer percentage (0-100). The CLI text formatter was multiplying by 100 again, producing values like 4400% instead of 44%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globalparticipationrateas an integer percentage (0-100), but thedora overviewtext formatter was multiplying by 100 again (rate*100), producing values like4400%instead of44%.*100multiplier so the displayed value matches the API response.Test plan
panda dora overviewnow shows44.00%matching the epoch API'sglobalparticipationrate: 44participation_rate: 44)