Skip to content

refactor(spec-specs): use kwargs for message call output collision returns#2238

Merged
spencer-tb merged 1 commit intoethereum:forks/amsterdamfrom
spencer-tb:backport/message-call-output-kwargs
Mar 5, 2026
Merged

refactor(spec-specs): use kwargs for message call output collision returns#2238
spencer-tb merged 1 commit intoethereum:forks/amsterdamfrom
spencer-tb:backport/message-call-output-kwargs

Conversation

@spencer-tb
Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb commented Feb 19, 2026

🗒️ Description

Backport required for EIP-8037.

🔗 Related Issues or PRs

Related specs PR: #2181
EIP Issue: #2040

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@spencer-tb spencer-tb added A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) P-high C-refactor Category: refactor labels Feb 19, 2026
@spencer-tb spencer-tb requested a review from SamWilsn February 19, 2026 13:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (834e482) to head (998c9aa).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2238   +/-   ##
================================================
  Coverage            86.07%   86.07%           
================================================
  Files                  599      599           
  Lines                39472    39472           
  Branches              3780     3780           
================================================
  Hits                 33977    33977           
  Misses                4862     4862           
  Partials               633      633           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb marked this pull request as draft February 19, 2026 19:17
@spencer-tb
Copy link
Copy Markdown
Contributor Author

Converting to draft for now until we know more about the future of 8037.

@spencer-tb spencer-tb marked this pull request as ready for review March 3, 2026 15:29
@spencer-tb spencer-tb merged commit a517953 into ethereum:forks/amsterdam Mar 5, 2026
17 checks passed
morph-dev pushed a commit to morph-dev/execution-specs that referenced this pull request Mar 18, 2026
…#2238)

Add more tests cases for the `p256verify` precompile where the final
computed point `R` is at infinity by passing `Q = -G` and `u1 == u2`.

Similar test cases exist in "wycheproof_extra".
flcl42 pushed a commit to flcl42/execution-specs that referenced this pull request Apr 10, 2026
…#2238)

Add more tests cases for the `p256verify` precompile where the final
computed point `R` is at infinity by passing `Q = -G` and `u1 == u2`.

Similar test cases exist in "wycheproof_extra".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-refactor Category: refactor P-high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants