Skip to content

bug(test-cli): fix extract config#1947

Merged
spencer-tb merged 2 commits intoethereum:forks/amsterdamfrom
marioevz:fix-extract-config
Jan 7, 2026
Merged

bug(test-cli): fix extract config#1947
spencer-tb merged 2 commits intoethereum:forks/amsterdamfrom
marioevz:fix-extract-config

Conversation

@marioevz
Copy link
Copy Markdown
Member

@marioevz marioevz commented Dec 22, 2025

🗒️ Description

Extracts the fix from #1901.

Also creates a GenesisState model for a cleaner code setup.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.33%. Comparing base (9e56ac9) to head (6903ebc).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #1947   +/-   ##
================================================
  Coverage            86.33%   86.33%           
================================================
  Files                  538      538           
  Lines                34557    34557           
  Branches              3222     3222           
================================================
  Hits                 29835    29835           
  Misses                4148     4148           
  Partials               574      574           
Flag Coverage Δ
unittests 86.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb added C-bug Category: this is a bug, deviation, or other problem A-test-cli Area: execution_testing.cli labels Jan 7, 2026
@spencer-tb spencer-tb changed the title Fix extract config bug(test-cli): fix extract config Jan 7, 2026
Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spencer-tb spencer-tb merged commit 125ff5e into ethereum:forks/amsterdam Jan 7, 2026
14 checks passed
CPerezz pushed a commit to CPerezz/execution-specs that referenced this pull request Feb 27, 2026
* fix(testing): Raise correct error on fixture parsing

* fix(test-cli): Cleaner extract_config

Co-authored-by: spencer <spencer.tb@ethereum.org>

---------

Co-authored-by: spencer <spencer.tb@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-cli Area: execution_testing.cli C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants