-
Notifications
You must be signed in to change notification settings - Fork 405
fix(test-tests): Use ZeroPaddedHexNumber instead of HexNumber for BALs
#1922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test-tests): Use ZeroPaddedHexNumber instead of HexNumber for BALs
#1922
Conversation
49ca8ed to
c277418
Compare
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #1922 +/- ##
==========================================================
Coverage ? 86.25%
==========================================================
Files ? 538
Lines ? 34561
Branches ? 3224
==========================================================
Hits ? 29809
Misses ? 4165
Partials ? 587
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
6967b93 to
be73122
Compare
c277418 to
ab17e06
Compare
danceratopz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this def looks like it addresses the issue at hand.
Added a dedicated BALs serialization roundtrip test that checks that values are zero-padded correctly here:
Did you intentionally leave HexNumber in test_block_access_list_t8n.py? I think we should update them there, too:
Otherwise, a couple of small comments below.
packages/testing/src/execution_testing/test_types/block_access_list/account_changes.py
Show resolved
Hide resolved
packages/testing/src/execution_testing/test_types/block_access_list/account_changes.py
Show resolved
Hide resolved
packages/testing/src/execution_testing/test_types/block_access_list/account_changes.py
Show resolved
Hide resolved
|
Thanks @danceratopz, can you run back through and make sure your comments are addressed and re-review? ππΌ |
be73122 to
ba0eec1
Compare
c6057a9 to
2b13f98
Compare
danceratopz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danceratopz, can you run back through and make sure your comments are addressed and re-review? ππΌ
There was just this remaining consistency nit:
Did you intentionally leave HexNumber in test_block_access_list_t8n.py? I think we should update them there, too:
https://github.com/fselmo/execution-specs/blob/ab17e0642769c0c9bc4b3a4a34ff21dfa09e7d3d/packages/testing/src/execution_testing/test_types/tests/test_block_access_list_t8n.py
But approving, as I don't want to block this PR any longer!
ποΈ Description
Use
ZeroPaddedHexNumberfor consistency with other fields in test vectors (e.g.0x0cinstead of0xc)π Related Issues or PRs
N/A.
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture