Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Dec 15, 2025

πŸ—’οΈ Description

Use ZeroPaddedHexNumber for consistency with other fields in test vectors (e.g. 0x0c instead of 0xc)

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2025-12-15 at 10 55 30

@fselmo fselmo added C-bug Category: this is a bug, deviation, or other problem A-test-tests Area: tests for packages/testing labels Dec 15, 2025
@fselmo fselmo changed the base branch from forks/amsterdam to eips/amsterdam/eip-7928 December 15, 2025 17:41
@fselmo fselmo force-pushed the fix/use-zero-padded-hex-number-bals branch from 49ca8ed to c277418 Compare December 15, 2025 17:52
@fselmo fselmo marked this pull request as ready for review December 15, 2025 17:55
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-7928@ba0eec1). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-7928    #1922   +/-   ##
==========================================================
  Coverage                           ?   86.25%           
==========================================================
  Files                              ?      538           
  Lines                              ?    34561           
  Branches                           ?     3224           
==========================================================
  Hits                               ?    29809           
  Misses                             ?     4165           
  Partials                           ?      587           
Flag Coverage Ξ”
unittests 86.25% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this def looks like it addresses the issue at hand.

Added a dedicated BALs serialization roundtrip test that checks that values are zero-padded correctly here:

Did you intentionally leave HexNumber in test_block_access_list_t8n.py? I think we should update them there, too:

https://github.com/fselmo/execution-specs/blob/ab17e0642769c0c9bc4b3a4a34ff21dfa09e7d3d/packages/testing/src/execution_testing/test_types/tests/test_block_access_list_t8n.py

Otherwise, a couple of small comments below.

@fselmo
Copy link
Contributor Author

fselmo commented Dec 17, 2025

Thanks @danceratopz, can you run back through and make sure your comments are addressed and re-review? πŸ™πŸΌ

@fselmo fselmo force-pushed the eips/amsterdam/eip-7928 branch from be73122 to ba0eec1 Compare December 17, 2025 22:12
@fselmo fselmo force-pushed the fix/use-zero-padded-hex-number-bals branch from c6057a9 to 2b13f98 Compare December 17, 2025 22:14
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danceratopz, can you run back through and make sure your comments are addressed and re-review? πŸ™πŸΌ

There was just this remaining consistency nit:

Did you intentionally leave HexNumber in test_block_access_list_t8n.py? I think we should update them there, too:
https://github.com/fselmo/execution-specs/blob/ab17e0642769c0c9bc4b3a4a34ff21dfa09e7d3d/packages/testing/src/execution_testing/test_types/tests/test_block_access_list_t8n.py

But approving, as I don't want to block this PR any longer!

@fselmo fselmo merged commit d32a78a into ethereum:eips/amsterdam/eip-7928 Dec 30, 2025
12 checks passed
@fselmo fselmo deleted the fix/use-zero-padded-hex-number-bals branch December 30, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tests Area: tests for packages/testing C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants