Skip to content

Conversation

@raxhvl
Copy link
Member

@raxhvl raxhvl commented Dec 14, 2025

πŸ—’οΈ Description

This PR add tests for the effects of EIP-7002 exit on EIP-7928.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

    |
    \\ A _.-''.-""
    /`''`    /
   |__  @)   |
    '-....--'\
              \
              |

@fselmo fselmo force-pushed the eips/amsterdam/eip-7928 branch from 6967b93 to be73122 Compare December 15, 2025 19:37
@raxhvl raxhvl marked this pull request as ready for review December 17, 2025 19:56
@raxhvl raxhvl force-pushed the feat/eip-7928/eip-7002-tests branch from 8015464 to d834aba Compare December 17, 2025 20:36
@fselmo fselmo force-pushed the eips/amsterdam/eip-7928 branch from be73122 to ba0eec1 Compare December 17, 2025 22:12
@fselmo fselmo force-pushed the feat/eip-7928/eip-7002-tests branch from d834aba to a362833 Compare December 17, 2025 22:20
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-7928@87cba98). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-7928    #1918   +/-   ##
==========================================================
  Coverage                           ?   86.25%           
==========================================================
  Files                              ?      538           
  Lines                              ?    34561           
  Branches                           ?     3224           
==========================================================
  Hits                               ?    29809           
  Misses                             ?     4165           
  Partials                           ?      587           
Flag Coverage Ξ”
unittests 86.25% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fselmo fselmo force-pushed the feat/eip-7928/eip-7002-tests branch from 37360ad to dcd7c9c Compare December 31, 2025 22:58
@fselmo fselmo added this to the amsterdam milestone Jan 5, 2026
@fselmo fselmo self-assigned this Jan 5, 2026
@fselmo fselmo force-pushed the feat/eip-7928/eip-7002-tests branch from dcd7c9c to 65c4fa8 Compare January 7, 2026 19:37
raxhvl and others added 3 commits January 7, 2026 12:41
πŸ₯’ nit:

✨ feat(tests): parameterised amount in clean sweep

✨ feat(tests): test_bal_7002_request_invalid

✨ feat(tests): test_bal_withdrawal_request_from_contract

✨ feat(tests): test_bal_7002_no_withdrawal_requests

♻️ refactor:

✨ feat(tests): parameter: validator key

✨ feat(tests): simplify

✨ feat(tests): test_bal_7002_partial_sweep

✨ feat(tests): test_bal_7002_clean_sweep

✨ feat: add more coverage

✨ feat:  test_bal_withdrawal_request_from_eoa
@fselmo fselmo force-pushed the feat/eip-7928/eip-7002-tests branch from 65c4fa8 to 3cc97c0 Compare January 7, 2026 19:42
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raxhvl this lgtm. I suspect there is a lot of overlap with the Prague 7002 tests that clients will have to agree on the BAL for but I think some smaller subset of those tests with BAL expectations is a good thing to have for readability of expectations - especially mapping out the expectation for no_withdrawal_requests.

I think this is pretty comprehensive for 7002 tests πŸ‘ŒπŸΌ. I just made one small fix balance_changes -> balance in Account classes (here) but the values there were correct and didn't break any test filling.

@fselmo fselmo merged commit 6b6d078 into ethereum:eips/amsterdam/eip-7928 Jan 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants