-
Notifications
You must be signed in to change notification settings - Fork 406
β¨ feat(tests): EIP-7928 tests targeting EIP-7002 #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ feat(tests): EIP-7928 tests targeting EIP-7002 #1918
Conversation
6967b93 to
be73122
Compare
8015464 to
d834aba
Compare
be73122 to
ba0eec1
Compare
d834aba to
a362833
Compare
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #1918 +/- ##
==========================================================
Coverage ? 86.25%
==========================================================
Files ? 538
Lines ? 34561
Branches ? 3224
==========================================================
Hits ? 29809
Misses ? 4165
Partials ? 587
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
37360ad to
dcd7c9c
Compare
dcd7c9c to
65c4fa8
Compare
π₯’ nit: β¨ feat(tests): parameterised amount in clean sweep β¨ feat(tests): test_bal_7002_request_invalid β¨ feat(tests): test_bal_withdrawal_request_from_contract β¨ feat(tests): test_bal_7002_no_withdrawal_requests β»οΈ refactor: β¨ feat(tests): parameter: validator key β¨ feat(tests): simplify β¨ feat(tests): test_bal_7002_partial_sweep β¨ feat(tests): test_bal_7002_clean_sweep β¨ feat: add more coverage β¨ feat: test_bal_withdrawal_request_from_eoa
65c4fa8 to
3cc97c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raxhvl this lgtm. I suspect there is a lot of overlap with the Prague 7002 tests that clients will have to agree on the BAL for but I think some smaller subset of those tests with BAL expectations is a good thing to have for readability of expectations - especially mapping out the expectation for no_withdrawal_requests.
I think this is pretty comprehensive for 7002 tests ππΌ. I just made one small fix balance_changes -> balance in Account classes (here) but the values there were correct and didn't break any test filling.
ποΈ Description
This PR add tests for the effects of EIP-7002 exit on EIP-7928.
π Related Issues or PRs
N/A.
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture