feat(schema): Update schema of engine_getBlobsV2 as per Osaka.md#781
Open
swastik7805 wants to merge 1 commit intoethereum:mainfrom
Open
feat(schema): Update schema of engine_getBlobsV2 as per Osaka.md#781swastik7805 wants to merge 1 commit intoethereum:mainfrom
engine_getBlobsV2 as per Osaka.md#781swastik7805 wants to merge 1 commit intoethereum:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #777
Fix: Align
engine_getBlobsV2result schema with Osaka specProblem
The result schema for
engine_getBlobsV2inblob.yamlonly declares an array return type. As perosaka.md, the method must returnnullwhenever any requested blob is missing, pruned, or unavailable — makingnulla primary return value, not an edge case.The current schema does not permit
null, creating a mismatch between themachine-readable specand theMarkdown specification.Change
Updated the result schema in
blob.yamlto useoneOf, allowing eitheran array ofBlobAndProofV2objects ornull.Fix
References
osaka.md— engine_getBlobsV2blob.yaml#L50@MysticRyuujin please review the issue and PR