Conversation
|
Good fixes overall, but two issues to address: 1. Wrong anchor for The PR changes the anchor from 2. Grammar in it returns as BlobsBundleV2 Should be: it returns BlobsBundleV2 Everything else looks correct:
|
SECONDS_PER_SLOT was deprecated in favor of SLOT_DURATION_MS in ethereum/consensus-specs#4476
Good find thanks. Fixed |
|
@mkalinin think you could review this one? |
| 1. `assert len(blobsBundle.commitments) == len(blobsBundle.blobs)` and | ||
| 2. `assert len(blobsBundle.proofs) == len(blobsBundle.blobs) * CELLS_PER_EXT_BLOB` and | ||
| 3. `assert verify_cell_kzg_proof_batch(commitments, cell_indices, cells, blobsBundle.proofs)` (see [EIP-7594 consensus-specs](https://github.com/ethereum/consensus-specs/blob/36d80adb44c21c66379c6207a9578f9b1dcc8a2d/specs/fulu/polynomial-commitments-sampling.md#verify_cell_kzg_proof_batch)) | ||
| 3. `assert verify_cell_kzg_proof_batch(commitments, cell_indices, cells, blobsBundle.proofs)` (see [EIP-7594 consensus-specs](https://github.com/ethereum/consensus-specs/blob/master/specs/fulu/polynomial-commitments-sampling.md#verify_cell_kzg_proof_batch)) |
There was a problem hiding this comment.
I think it would be more stable to have a link anchored to a specific commit. wdyt?
There was a problem hiding this comment.
I guess it's a choice to make. My intuition is that the specs should not change drastically and master branch is considered the latest stable version.
This PR fixes a few nits I've found while reviewing specs.