css: restore URL wrapping in pad editor (#7894)#7896
Open
JohnMcLear wants to merge 3 commits into
Open
Conversation
Long URLs in the pad editor overflow instead of wrapping because the
global a { white-space: nowrap } rule in pad.css overrides the wrapping
properties set on #innerdocbody. Add explicit white-space, word-wrap,
and overflow-wrap to #innerdocbody a so URLs wrap inside the editor
while preserving no-wrap behavior for links elsewhere in the UI.
Fixes ether#7894
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Review Summary by QodoFix URL wrapping in pad editor
WalkthroughsDescription• Fix URL wrapping in pad editor by overriding global no-wrap rule • Add explicit white-space, word-wrap, and overflow-wrap properties • Preserve no-wrap behavior for links elsewhere in UI Diagramflowchart LR
A["Global a rule<br/>white-space: nowrap"] -->|"overrides"| B["#innerdocbody a<br/>wrapping properties"]
B -->|"Add explicit CSS"| C["#innerdocbody a<br/>white-space: normal<br/>word-wrap: break-word<br/>overflow-wrap: break-word"]
C -->|"Result"| D["URLs wrap in editor<br/>No-wrap preserved elsewhere"]
File Changes1. src/static/css/iframe_editor.css
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long URLs in the pad editor overflow instead of wrapping because the global
a { white-space: nowrap }rule inpad.cssoverrides the wrapping properties set on#innerdocbody. Add explicitwhite-space,word-wrap, andoverflow-wrapto#innerdocbody aso URLs wrap inside the editor while preserving no-wrap behavior for links elsewhere in the UI.Fixes #7894