Fix: correct type hint for message to allow None#2531
Merged
Badiboy merged 1 commit intoeternnoir:masterfrom Dec 6, 2025
Merged
Fix: correct type hint for message to allow None#2531Badiboy merged 1 commit intoeternnoir:masterfrom
Badiboy merged 1 commit intoeternnoir:masterfrom
Conversation
Collaborator
|
Resonable, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The attribute
messagecan beNonein practice, but the type hint only allowedMessage | InaccessibleMessage.This PR updates it to:
This prevents false positives in type checkers (Pyright, MyPy, Pylance) and reflects the real behavior.
Describe your tests
Although the change doesn't require its own test, I ran the tests and detected no errors.
Python version: 3.13
OS: Windows 11
Checklist: