Add missing/incomplete type annotations#2487
Closed
gameroman wants to merge 1 commit intoeternnoir:masterfrom
Closed
Add missing/incomplete type annotations#2487gameroman wants to merge 1 commit intoeternnoir:masterfrom
gameroman wants to merge 1 commit intoeternnoir:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing type annotations to improve code clarity and type checking in the telebot module.
- Updated the add() method signature in InlineKeyboardMarkup to provide type annotations for *args and row_width.
- Specifies that *args should be of type InlineKeyboardButton and makes row_width an Optional[int].
Comments suppressed due to low confidence (1)
telebot/types.py:2895
- Ensure that 'Optional' is imported from the typing module, and consider adding a short inline comment to clarify that *args should be instances of InlineKeyboardButton.
def add(self, *args: InlineKeyboardButton, row_width: Optional[int] = None) -> 'InlineKeyboardMarkup':
Collaborator
|
Your PR is in draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your tests
How did you test your change? Type checker
Python version: 3.13
OS: Windows
Checklist: