Fix states functions with new parameters#2473
Merged
Badiboy merged 1 commit intoeternnoir:masterfrom Apr 22, 2025
Merged
Conversation
... and some minor issues.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates state and data management functions to support new parameters and adjusts function calls to match the updated signatures.
- Updated method signatures in both synchronous and asynchronous storage classes to include new optional parameters (business_connection_id, message_thread_id, and bot_id).
- Revised type hints in the asyncio context and updated function calls in telebot/async_telebot.py and telebot/init.py to use positional arguments for chat_id and state-related parameters.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| telebot/storage/base_storage.py | Updated state and data methods to support new optional parameters. |
| telebot/states/asyncio/context.py | Updated init type hint for the bot parameter. |
| telebot/asyncio_storage/base_storage.py | Updated async method signatures with additional optional parameters. |
| telebot/async_telebot.py | Updated calls to state functions and refined the poll options type. |
| telebot/init.py | Consistent updates to state function calls with new parameter handling. |
Collaborator
Author
|
@coder2020official , please take a look: I just cover warnings given by IDE. |
Collaborator
|
LGTM |
coder2020official
approved these changes
Apr 22, 2025
hossen71
reviewed
May 7, 2025
datboidatway
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix states functions with new parameters
... and some minor issues.