Merged
Conversation
Collaborator
Author
|
@Badiboy done with the bot api, you can start reviewing |
Badiboy
reviewed
Jan 3, 2025
| @@ -2271,12 +2301,6 @@ def convert_input_media_array(array): | |||
| if media_dict['media'].startswith('attach://'): | |||
| key = media_dict['media'].replace('attach://', '') | |||
| files[key] = input_media.media | |||
Collaborator
There was a problem hiding this comment.
What is the reason for removing this code?
telebot/async_telebot.py
Outdated
| :return: Returns True on success. | ||
| :rtype: :obj:`bool` | ||
| """ | ||
| return await asyncio_helper.verify_user(self.token, user_id, custom_description) |
Collaborator
There was a problem hiding this comment.
May be it's time to start sending optional parameters as named?
| @@ -2243,12 +2269,6 @@ async def convert_input_media_array(array): | |||
| if media_dict['media'].startswith('attach://'): | |||
| key = media_dict['media'].replace('attach://', '') | |||
| files[key] = input_media.media | |||
Collaborator
There was a problem hiding this comment.
The same here: what is the reason for removing this code?
telebot/version.py
Outdated
| # Versions should comply with PEP440. | ||
| # This line is parsed in setup.py: | ||
| __version__ = '4.25.0' | ||
| __version__ = '4.24.0' |
Collaborator
|
Looks like you made PR not from the recent version... |
Collaborator
Author
|
@Badiboy sorry for that, it did not somehow show up on the changelog for me. |
Badiboy
approved these changes
Jan 3, 2025
Collaborator
|
Thank you! Release? |
Collaborator
Author
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
January 1, 2025
Bot API 8.2