-
Notifications
You must be signed in to change notification settings - Fork 8
Added Docker image for older ARMv7 architecture support because of glibc issues #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hello jakub-kocka, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
643ce4d to
02bbd49
Compare
02bbd49 to
7c2f199
Compare
peterdragun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this fixes the issue for us in the esptool. Thank you!
7c2f199 to
bdf9bd8
Compare
dobairoland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| # Build and install patchelf from source to ensure proper ELF alignment on ARM | ||
| # System patchelf versions can cause "ELF load command address/offset not properly aligned" errors | ||
| RUN cd /tmp && \ | ||
| git clone https://github.com/NixOS/patchelf.git && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could fetch just the branch in order to speed up the process. Full clone is not necessary.
|
|
||
| ## Docker files | ||
| Docker files are here just as a copy for better understanding in the scope of one repository. Actual Docker files are in its own repository where there are build and published from. https://github.com/espressif/github-esp-dockerfiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then why to keep a copy here? Isn't it just a maintenance burden for us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I will remove it and reword this section.
Description
I have dropped Python 3.14 support for the legacy ARMv7 runner because it would bring more implementation issues, and I believe the time period between these old OSes and Python 3.14 is significant enough not to support it.
Related
Internal related tracker: IDFCI-8006
Testing
Action run: https://github.com/espressif/idf-python-wheels/actions/runs/20991228759
Checklist
Before submitting a Pull Request, please ensure the following: