Skip to content

Conversation

@WatcherOfTheSkies
Copy link
Contributor

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:

  • All recent builds.

  • Issues fixed (if any):

  • The intended error message will now be displayed for two cases.

  • The formatting is improved to make reading easier.

  • n.b. It's not clear what the variables perr and herr really are.

  • The error message will mostly append a ':' even if an error is not forthcoming.

  • Brief description of code changes (suitable for use as a commit message):

  • Fixed missing 'break;'s and improved formatting.

@bmah888 bmah888 self-assigned this Jan 8, 2026
@bmah888
Copy link
Contributor

bmah888 commented Jan 8, 2026

Yegads that's embarrassing. One of the two problems can trivially be tested like this:

% iperf3 --client localhost --udp --file fubar.dat
iperf3: parameter error - invalid unit value or suffix: '(null)'

Usage: iperf3 [-s|-c host] [options]
Try `iperf3 --help' for more information.

That's the wrong error message. The correct error message (produced with your PR) is actually iperf3: parameter error - cannot transfer file using UDP

Thanks for the PR! Merging shortly.

@bmah888 bmah888 merged commit 62ade9c into esnet:master Jan 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants