Conversation
This switches to ESM only, which means: - We drop `tshy` and just use TypeScript directly - Use import attributes (i.e. import the JSON directly using `import`) This does mean we require a newer Node, one that can `require(esm)` and use import attributes (specifically JSON).
Contributor
Author
|
@bluwy this does mean our ESLint plugin will also require Node 20. so if we wanted to keep 18.x support, i think we'd need one of the following:
thoughts? |
| "require": { | ||
| "types": "./dist/commonjs/main.d.ts", | ||
| "default": "./dist/commonjs/main.js" | ||
| "types": "./dist/main.d.ts", |
Contributor
There was a problem hiding this comment.
What do you think of us also adding to the package json the node version minimum for the package ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches to ESM only, which means:
tshyand just use TypeScript directlyimport)This does mean we require a newer Node, one that can
require(esm)anduse import attributes (specifically JSON).
🔗 Linked issue
📚 Description