Guard disk_free_space() and disk_total_space() with function_exists()#112
Open
Giermann wants to merge 3 commits intoerror311:masterfrom
Open
Guard disk_free_space() and disk_total_space() with function_exists()#112Giermann wants to merge 3 commits intoerror311:masterfrom
Giermann wants to merge 3 commits intoerror311:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileModel::createZipArchive()andFolderControllercalldisk_free_space()without checking whether the function exists. This causes a fatal error on hosts where the function is indisable_functions. The fix wraps the call:The same fix is needed in
DiskUsageModeland in the admin panel disk usage display.The same guard should be applied to any other host-restricted functions called without
function_exists()checks.