Fix Dashboard auto-refresh stalling with stop/start timer#834
Merged
erikdarlingdata merged 1 commit intodevfrom Apr 12, 2026
Merged
Fix Dashboard auto-refresh stalling with stop/start timer#834erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
The _isRefreshing guard in LoadDataAsync could get permanently stuck if any SQL query hung (connection drop, slow timeout), silently killing all subsequent auto-refresh ticks. Replaced with a stop/start pattern: the timer stops before each tick and restarts in finally, bypassing LoadDataAsync entirely for auto-refresh. This guarantees the timer always restarts regardless of what happens during the refresh. Also removed the redundant _isRefreshing guard from CorrelatedTimelineLanesControl.RefreshAsync which was independently causing Server Trends charts to silently skip updates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_isRefreshingguard — timer stops before each tick, restarts infinally, guaranteeing it always resumesRefreshVisibleTabAsyncdirectly, bypassingLoadDataAsyncand its_isRefreshinggate that could get permanently stuck on hung SQL queries_isRefreshingguard fromCorrelatedTimelineLanesControl.RefreshAsyncthat was independently causing Server Trends charts to silently skip updatesTest plan
🤖 Generated with Claude Code