Fix #1048: show "Other: n/a" instead of "Other: 0%" on Linux#1062
Merged
Conversation
On Linux the alert engine returns host/other-process CPU as NULL (no DMV exposes true host CPU there; SystemIdle is always 0). CpuDisplayText already drops the Other figure, but CpuDetailText coalesced the NULL to 0, rendering a misleading "Other: 0%" that reads as a real zero measurement. Branch on .HasValue so a missing value renders "n/a", matching the honest treatment in CpuDisplayText. No query or datatype change; the value stays int?/NULL and only the final display string differs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On Linux, the alert engine correctly returns host/other-process CPU as
NULL(no DMV exposes true host CPU there;SystemIdleis always 0 inRING_BUFFER_SCHEDULER_MONITOR).CpuDisplayTextalready drops the Other figure on Linux, butCpuDetailTextcoalesced theNULLto0, rendering a misleading "Other: 0%" that reads as a real zero measurement.This branches
CpuDetailTexton.HasValueso a missing value renders "n/a", matching the honest treatment already inCpuDisplayText.Why
Follow-up to #1055. The reporter (running SQL Server on OpenSUSE) confirmed the alert no longer fires, then asked whether "Other: 0%" was a real reading or a placeholder. It was a placeholder — this makes the UI say so.
Scope
Dashboard/Models/ServerHealthStatus.csint?/NULLend to end; only the final display string differs.Testing
Builds clean (0 warnings, 0 errors). Runtime path is a display-string branch; not runtime-tested (no Linux SQL host available locally).
🤖 Generated with Claude Code