Skip to content

Security: Potential path traversal when saving models to disk #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuanaiseo wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Security: Potential path traversal when saving models to disk #1104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion discojs-node/src/model_loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import fs from "node:fs/promises";
import path from "node:path";

import type { models, DataType } from "@epfml/discojs";
import { serialization } from "@epfml/discojs";
Expand All @@ -10,8 +11,20 @@ export async function saveModelToDisk(
): Promise<void> {
const encoded = await serialization.model.encode(model);

if (
path.isAbsolute(modelFileName) ||
modelFileName.includes("/") ||
modelFileName.includes("\\") ||
modelFileName === "." ||
modelFileName === ".."
) {
throw new Error("Invalid model file name");
}

const modelPath = path.join(modelFolder, modelFileName);

await fs.mkdir(modelFolder, { recursive: true });
await fs.writeFile(`${modelFolder}/${modelFileName}`, encoded);
await fs.writeFile(modelPath, encoded);
}

export async function loadModelFromDisk(
Expand Down