-
Notifications
You must be signed in to change notification settings - Fork 34
Add Kafka documentation for empty topic consumer behavior and batched produce routing #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
phlax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kafka-mesh/example.rst
Outdated
| ******************************************************* | ||
|
|
||
| In production, Kafka producers often batch multiple records into a single | ||
| ProduceRequest to improve throughput. The mesh filter must correctly handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ProduceRequest to improve throughput. The mesh filter must correctly handle | |
| ``ProduceRequest`` to improve throughput. The mesh filter must correctly handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in c53084e
kafka-mesh/example.rst
Outdated
| these batched requests and route records to the appropriate upstream cluster. | ||
|
|
||
| Send multiple messages rapidly to the ``cherries`` topic (which routes to | ||
| cluster1 based on the ``c`` prefix). The producer will automatically batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cluster1 based on the ``c`` prefix). The producer will automatically batch | |
| ``cluster1`` based on the ``c`` prefix). The producer will automatically batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in c53084e
kafka-mesh/example.rst
Outdated
| echo \"cherry message \$i\"; \ | ||
| done | kafka-console-producer --request-required-acks 1 --producer-property enable.idempotence=false --broker-list proxy:10000 --topic cherries" | ||
|
|
||
| Now verify that all 20 messages arrived at cluster1 by consuming directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Now verify that all 20 messages arrived at cluster1 by consuming directly | |
| Now verify that all 20 messages arrived at ``cluster1`` by consuming directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in c53084e
kafka-mesh/example.rst
Outdated
| 20 | ||
|
|
||
| This confirms that even though the producer may have batched the records into | ||
| multiple ProduceRequests, the mesh filter correctly routed all messages to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| multiple ProduceRequests, the mesh filter correctly routed all messages to the | |
| multiple ``ProduceRequest``s, the mesh filter correctly routed all messages to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in c53084e
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Implementation Plan for Kafka Documentation and Tests
Overview
Add documentation and verification tests to replace Envoy integration tests that are being moved from the main envoy repository.
Checklist
Kafka Broker - Empty Topic / Consumer Waiting Behavior
kafka/example.rstdocumenting:kafka/verify.sh:Kafka Mesh - High-Volume / Batched Producing
kafka-mesh/example.rstdocumenting:kafka-mesh/verify.sh:Code Review Fixes
Validation
kafka/verify.shto ensure changes work correctly ✅kafka-mesh/verify.shto ensure changes work correctly ✅Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.