secret_provider: atomically replace thread-local-storage value#44289
Open
adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
Open
secret_provider: atomically replace thread-local-storage value#44289adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
adisuissa wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
kyessenov
approved these changes
Apr 14, 2026
Contributor
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
I'm not sure this is faster, but it's safe AFAICT and a bit more robust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: secret_provider: atomically replace thread-local-storage value
Additional Description:
Refactor the code to use the
set()pattern that does an immutable atomic replacement of the thread-local-storage value rather than updating the pointed value contents.Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A