Skip to content

excluded_controls para geolift#66

Open
KarlaMelgarejo wants to merge 4 commits intoentropyx:devfrom
KarlaMelgarejo:feat/excluded-controls
Open

excluded_controls para geolift#66
KarlaMelgarejo wants to merge 4 commits intoentropyx:devfrom
KarlaMelgarejo:feat/excluded-controls

Conversation

@KarlaMelgarejo
Copy link
Copy Markdown
Collaborator

Add ability to exclude specific locations from the control group selection process. The parameter is propagated through the full pipeline:

  • select_controls() and select_controls_exclusive()
  • evaluate_group() and evaluate_group_exclusive()
  • BetterGroups() including all executor.map calls (single-cell, multi-cell, global)
  • run_geo_analysis_streamlit_app()
  • experimental_design.py UI widget (below excluded_locations)
  • api.py Form parameter with parsing
  • tasks.py Celery task parameter

KarlaMelgarejo and others added 4 commits February 27, 2026 18:30
Add ability to exclude specific locations from the control group selection
process. The parameter is propagated through the full pipeline:
- select_controls() and select_controls_exclusive()
- evaluate_group() and evaluate_group_exclusive()
- BetterGroups() including all executor.map calls (single-cell, multi-cell, global)
- run_geo_analysis_streamlit_app()
- experimental_design.py UI widget (below excluded_locations)
- api.py Form parameter with parsing
- tasks.py Celery task parameter

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…aluation

- Rename excluded_locations -> excluded_treatment_locations across all files
- Rename excluded_controls -> excluded_control_locations across all files
- Add excluded_control_locations parameter to run_geo_evaluation() in post_analysis.py
- Add excluded_control_locations widget in experimental_evaluation.py UI
- Add logging of excluded_control_locations in run_geo_analysis_streamlit_app
- Add validation in run_geo_evaluation for empty pre-treatment period with clear error message
- Handle ValueError gracefully in experimental_evaluation.py UI

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant