Merged
Conversation
As delivered by PixelFrog. Update the position of elements in the corresponding scenes too. Move the sprite and adjust the marker and control for hooking. They only differ in a few pixels so it shouldn't be any gameplay regression.
|
Play this branch at https://play.threadbare.game/branches/endlessm/integrate-grappling-hook-assets/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
changed the title
PixelFrog has delivered 2 new assets: an indicator pointing down and another pointing up. The "up" should be used in the player. And this commit does so. The "down" will be used as indicator in things that can be hooked, and potentially for indicating other things on screen. Use the "up" indicator in the HookControl, rotated by 90 degrees. Put these assets in assets/first_party/ because they can be multipurpose. Remove the previous arrow asset.
manuq
force-pushed
the
integrate-grappling-hook-assets
branch
from
a645819 to
a59fb48
Compare
Collaborator
Author
|
This is the usage explanation by PixelFrog:
|
wjt
reviewed
Apr 14, 2026
|
|
||
| [node name="Sprite2D" type="Sprite2D" parent="." unique_id=1242315016] | ||
| position = Vector2(0, -32) | ||
| position = Vector2(0, -24) |
Member
There was a problem hiding this comment.
As an aside - I read somewhere that it's better to use Sprite2D.offset rather than adjusting its position, but I can't remember why. Not specific to this PR of course.
wjt
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate new pin and needle assets
As delivered by PixelFrog.
Update the position of elements in the corresponding scenes too. Move the sprite and adjust the marker and control for hooking. They only differ in a few pixels so it shouldn't be any gameplay regression.
Integrate new arrow indicator
PixelFrog has delivered 2 new assets: an indicator pointing down and another
pointing up. The "up" should be used in the player. And this commit does so. The
"down" will be used as indicator in things that can be hooked, and potentially
for indicating other things on screen.
Use the "up" indicator in the HookControl, rotated by 90 degrees.
Put these assets in assets/first_party/ because they can be multipurpose.
Remove the previous arrow asset.
Resolve #2117
Resolve #2118