Conversation
The desired behaviour is that when the player returns to this scene after collecting the powerup, a music transition to Creep Outro is triggered. Creep Loop will be playing, so this allows it to reach its natural end, then play an outro, and transition to Still in preparation for the next scene, void_grappling. Previously this was achieved by having a second copy of this scene, grappling_hook_end, which set BackgroundMusic.clip to "Creep Outro". However since commit b86ea32 this scene was removed. As a result the music was switched to Creep Intro when returning to this scene. Change BackgroundMusic.switch_to_clip() into a setter for BackgroundMusic.clip, so that it can be used before BackgroundMusic.play() has been called (from _ready()). (This has the nice side-benefit that you can now test AudioStreamInteractive transitions in the editor by hitting Play in the inspector then adjusting the Clip property!) In grappling_hook_start, add a ClipSwitcher, triggered by the player being teleported, in the same way that we disable the opening dialogue in that case. Update ink_combat_round_6 to use ClipSwitcher, matching ink_combat_round_3. Resolves #2110
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/grappling-hook-start-switch-to-creep-outro-when-returning-from-powerup/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Apr 14, 2026
Collaborator
manuq
left a comment
There was a problem hiding this comment.
I didn't realize that I broke this, sorry.
Is very nice to test the music transitions in the editor. I spent some time clicking Play and then changing the Clip.
The clips I see now in a playthrough are:
- Creep Intro in grappling_hook_start, the first time.
- Creep Loop in the levels in between.
- Creep Outro in grappling_hook_start, when returning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desired behaviour is that when the player returns to this scene
after collecting the powerup, a music transition to Creep Outro is
triggered. Creep Loop will be playing, so this allows it to reach its
natural end, then play an outro, and transition to Still in preparation
for the next scene, void_grappling.
Previously this was achieved by having a second copy of this scene,
grappling_hook_end, which set BackgroundMusic.clip to "Creep Outro".
However since commit b86ea32 this scene
was removed. As a result the music was switched to Creep Intro when
returning to this scene.
Change BackgroundMusic.switch_to_clip() into a setter for
BackgroundMusic.clip, so that it can be used before
BackgroundMusic.play() has been called (from _ready()). (This has the
nice side-benefit that you can now test AudioStreamInteractive
transitions in the editor by hitting Play in the inspector then
adjusting the Clip property!)
In grappling_hook_start, add a ClipSwitcher, triggered by the player
being teleported, in the same way that we disable the opening dialogue
in that case.
Update ink_combat_round_6 to use ClipSwitcher, matching
ink_combat_round_3.
Resolves #2110